Artifact qiita_db fixes #1535
Merged
Artifact qiita_db fixes #1535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fact-fix-search
|
I guess this should have fixed the errors but the tests are failing in the same place ... |
|
👍 |
There was a problem hiding this comment.
Is the if datatypes is not None ... needed at all?
There was a problem hiding this comment.
Yup in order to avoid this issue:
In [1]: a = None
In [2]: '1' in a
---------------------------------------------------------------------------
TypeError Traceback (most recent call last)
<ipython-input-2-096bed3860b1> in <module>()
----> 1 '1' in a
TypeError: argument of type 'NoneType' is not iterable
|
Looks good, though I'm not exactly sure why some command line interfaces were deleted altogether, if this is because everything is now an artifact, then it makes sense, otherwise, I'm not sure I quite understand. 👍 |
This was referenced Nov 18, 2015
Closed
Merged
|
That is correct @ElDeveloper everything is now an artifact, so there is no point on having those other commands. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR depends on #1532 so review/merge that one first.
This PR should fix all the issues in the Qiita DB submodule.