Fixing more tests #1532
Merged
Fixing more tests #1532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@josenavas obviously we need to wait to review the other PRs before we review this but looking at the errors in the build I think there is something not right ... could you take a look? My concern is that the DB is not being created. |
…fact-fixing-more-stuff
|
👍 |
qiita_db/portal.py
Outdated
|
👍 Just two small comments. |
|
Thanks @josenavas, let's wait for the tests, but this looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR depends on #1531, so review/merge that one first.
This PR fixes the tests for software, portal, test_sql.py and util.
The software and portal objects have been modified to return instances of other objects rather than the ids.