-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove google/__init__.pyi #6106
Conversation
Since google is a namespace package, it won't have an init. Depends on typeshed-internal/stub_uploader#33
Waiting for the mypy change might not be a good idea; it's likely going to take a while. |
I've made some progress with python/mypy#11257 , python/mypy#11259 , python/mypy#11261 . That being said - this doesn't strictly depend on it, but it will confuse everyone using protobuf stubs - since they'll have to add this
^ both of these have gotten in! |
Is this PR viable now? |
Ideally python/mypy#9636 gets in first. I think it is ready, though I sense some hesitancy in the thread there. Otherwise, we'll have to educate a lot of folks to pass If we think python/mypy#9636 will have a lot of delay - I can instead look into alternate ways to encourage people to set |
Ok, lets wait for mypy 0.940, in case python/mypy#9636 goes into it. If it doesn't make 0.940 for some reason, we can merge it here first. |
Now that 0.940 has been released can we merge this? My interest is that the lack of this, means pyright produces a number of errors when google libraries are imported and that google stub information gets lost. At moment I've mostly just followed a practice of type ignore and let several google libraries behave like Any. |
I'm OK with merging this. @hauntsaninja do you think the namespace packages change will make it into mypy soon? |
Probably 🤷 I'm fine with this being merged whenever, since it's impacting users of other type checkers. |
Hi! Please revert due to #7519 ! |
This reverts commit a11a664.
Since google is a namespace package, it won't have an init.
Depends on typeshed-internal/stub_uploader#33 - so the stub uploader can handle it
Should wait until
microsoft/pyright@5e38fab gets in. See discussion
May also want to wait until python/mypy#9636 gets in - as it'll be confusing for folks to have to add the
--namespace-packages
flag to mypy for things to work.