Fix case mismatching modules during namespace package search #11261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 4, 2021
hauntsaninja
reviewed
Oct 4, 2021
For example `from a import B` should not find a namespace package `a/B/`. Fix by using case aware isdir on fscache.
nipunn1313
force-pushed
the
insensitive
branch
from
b7ba9a0 to
554f7f9
Compare
|
makes sense to me - switched it back to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example
from a import Bshould not find a namespacepackage
a/B/. Fix by using case aware isdir on fscache.Helps unblock #9636
Test Plan
There are several existing tests for this area. I split one of the tests by namespace package for straddling.
I also tested this diff on top of #9636 and confirmed it helps!