incremental testsuite: don't write subsequent step files until they are needed #11257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nipunn1313
force-pushed
the
incremental
branch
from
491597c to
285faf9
Compare
nipunn1313
commented
Oct 4, 2021
| @@ -638,6 +638,7 @@ import p2.m2 | |||
| p1/m1.py:1: error: "int" not callable | |||
| main.py:2: error: Cannot find implementation or library stub for module named "p2.m2" | |||
| main.py:2: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports | |||
| main.py:2: error: Cannot find implementation or library stub for module named "p2" | |||
There was a problem hiding this comment.
This now happens because the flags have --namespace-packages for this test! Before, p2 was being found as a namespace package because it contained p2/m2.py.2. This sort of error is happening all over the place in #9636
| os.makedirs(dir, exist_ok=True) | ||
| with open(path, 'w', encoding='utf8') as f: | ||
| f.write(content) | ||
| m = re.match(r'.*\.([0-9]+)$', path) |
There was a problem hiding this comment.
I moved this stuff so I could combine the re.match logic.
I wonder if we can totally eliminate find_steps and just inject the steps as an arg to suite.run_test()
…re needed This matters with namespace packages - since an empty package with some .2 files in it will be considered a namespace package. This is truer - by only writing the files at the point of the step. This helps unblock python#9636
nipunn1313
force-pushed
the
incremental
branch
from
285faf9 to
29603b6
Compare
This was referenced Oct 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This matters with namespace packages enabled - since an (otherwise) empty folder with
some .2 files in it will be considered a namespace package. This is
truer - by only writing the files at the point of the step. This helps
unblock #9636
Test Plan
I confirmed that this helps fix some of the failures in #9636. I confirmed all preexisting tests continue to work.