Skip to content

run stubtest on python 3.10 #5305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
May 2, 2021
Merged

run stubtest on python 3.10 #5305

merged 18 commits into from
May 2, 2021

Conversation

@Akuli
Copy link
Collaborator

@Akuli Akuli commented May 2, 2021 •
edited
Loading

To do:

  • enable stubtest_unused.py
  • figure out which py310.txt lines are linux-specific, put them to linux-py310.txt

@JelleZijlstra
Copy link
Member

JelleZijlstra commented May 2, 2021

3.10-dev might work?

@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2021

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

2 similar comments
@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2021

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2021

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

Akuli added 8 commits May 2, 2021 17:30
@Akuli
add missing stuff to whitelist
8959d7f 
python -m mypy.stubtest --ignore-missing-stub --check-typeshed --custom-typeshed-dir . --whitelist tests/stubtest_whitelists/py3_common.txt --whitelist tests/stubtest_whitelists/py310.txt --ignore-unused-whitelist --whitelist tests/stubtest_whitelists/linux.txt --generate-whitelist
@Akuli
run tests/stubtest_unused.py
c895b20
@Akuli
enable tests/stubtest_unused.py
c29dc18
@Akuli
improve comment
3370041
@Akuli
TEMPORARY: change stubtest_test output
f4312ac
@Akuli
make win32 whitelist
9f31e37
@Akuli
Revert "TEMPORARY: change stubtest_test output"
8425172 
This reverts commit f4312ac.
@Akuli
TEMPORARY: change stuff for win32-py310.txt
d6babf3 
TEMPORARY: change stubtest_test output
@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2021

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

Akuli
Akuli commented May 2, 2021
View reviewed changes
@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2021

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@Akuli Akuli marked this pull request as ready for review May 2, 2021 15:03
@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2021

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@Akuli Akuli mentioned this pull request May 2, 2021
Closed
@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2021

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2021

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2021

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

3 similar comments
@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2021

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2021

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2021

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

srittau
srittau approved these changes May 2, 2021
View reviewed changes
Copy link
Collaborator

@srittau srittau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@srittau srittau merged commit 7590506 into python:master May 2, 2021
@Akuli Akuli deleted the stubtest-310 branch May 2, 2021 16:16
@hauntsaninja
Copy link
Collaborator

hauntsaninja commented May 2, 2021

Thanks for doing this, but I think I might roll back this change for now:

  • This is running with an older alpha, so is currently getting in the way of changes
  • With 3.9, even post-beta, we ended up having to switch off stubtest in CI for a while because the level of breakage was too high
  • This PR will likely also cause problems with unused, I imagine there are some things that will need to be removed from py3_common
  • We also at some point need to move the positional-only test to use 3.10 (we only check positional-only compatibility on latest version)

Akuli added a commit that referenced this pull request May 2, 2021
@Akuli
Revert "run stubtest on python 3.10 (#5305)"
e3f4f03 
This reverts commit 7590506.
hauntsaninja pushed a commit to hauntsaninja/typeshed that referenced this pull request May 2, 2021
Disable py310 stubtest in CI for now
d78b062 
This was enabled in python#5305

- This is running with an older alpha, so is currently getting in the
  way of changes

- With 3.9, even post-beta, we ended up having to switch off stubtest in
  CI for a while because the level of breakage was too high

- This PR will likely also cause problems with unused, I imagine there
  are some things that will need to be removed from py3_common

- We also at some point need to move the positional-only test to use
  3.10 (we only check positional-only compatibility on latest version)
@Akuli Akuli mentioned this pull request May 2, 2021
Merged
hauntsaninja pushed a commit that referenced this pull request May 2, 2021
@Akuli
Revert "run stubtest on python 3.10 (#5305)" (#5311)
7dffcb5 
This reverts commit 7590506.
@Akuli Akuli mentioned this pull request May 2, 2021
Closed
@Akuli Akuli restored the stubtest-310 branch May 2, 2021 20:27
@Akuli Akuli mentioned this pull request May 2, 2021
Closed
Akuli added a commit to Akuli/typeshed that referenced this pull request May 2, 2021
@Akuli
run stubtest on python 3.10 (python#5305)
746e82c
@Akuli Akuli mentioned this pull request May 2, 2021
Merged
6 tasks
@Akuli Akuli deleted the stubtest-310 branch May 2, 2021 20:35
@Akuli Akuli mentioned this pull request May 2, 2021
Merged
@Akuli Akuli restored the stubtest-310 branch May 3, 2021 09:24
@Akuli Akuli deleted the stubtest-310 branch May 6, 2021 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@srittau srittau srittau approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Akuli @JelleZijlstra @hauntsaninja @srittau