Skip to content

Conversation

@Akuli
Copy link
Collaborator

@Akuli Akuli commented May 2, 2021

Suggested by @hauntsaninja in #5305

Copy link
Collaborator

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'd keep the allowlists around, so we don't have to duplicate the work you did of separating out different OS errors (but git is forever, so shrug) :-)

@Akuli
Copy link
Collaborator Author

Akuli commented May 2, 2021

Maybe we should instead merge this commit you did ?

@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2021

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@hauntsaninja hauntsaninja merged commit 7dffcb5 into master May 2, 2021
@hauntsaninja hauntsaninja deleted the revert-5305-stubtest-310 branch May 2, 2021 19:55
@hauntsaninja
Copy link
Collaborator

Then we'd have to wait 20m for CI to finish ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants