enum: update for py310 #5314
Merged
enum: update for py310 #5314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I remember there are some subtleties around Enum.__new__, that might be relevant to StrEnum, but I'm forgetting the details. I wasn't sure how best to handle the new enum.property. I could also re-export, or take a more literal interpretation.
Akuli
reviewed
May 2, 2021
| if sys.version_info >= (3, 10): | ||
| class StrEnum(str, Enum): | ||
| def __new__(cls: Type[_T], value: Union[int, _T]) -> _T: ... | ||
| class FlagBoundary(StrEnum): |
There was a problem hiding this comment.
This is not used anywhere. Is there no way to say "class Foo(Flag, boundary=...) takes a boundary argument of this type?
There was a problem hiding this comment.
Don't think so: python/mypy#2653. Perhaps we can add a stub for __init_subclass__ or __new__ or whatever black magic enum is doing to implement this.
|
In #5305 I noticed that |
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
JelleZijlstra
approved these changes
May 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I remember there are some subtleties around Enum.new, that might be
relevant to StrEnum, but I'm forgetting the details.
I wasn't sure how best to handle the new enum.property. I could also
re-export, or take a more literal interpretation.