bpo-40275: Use new test.support helper submodules in tests #21450
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shihai1991
requested review from
brettcannon,
encukou,
ericsnowcurrently,
ncoghlan and
warsaw
as code owners
|
cc @vstinner |
vstinner
reviewed
Aug 3, 2020
| from test.support.import_helper import (forget, make_legacy_pyc, unlink, | ||
| unload, DirsOnSysPath) | ||
| from test.support.os_helper import (TESTFN, rmtree, temp_umask, | ||
| TESTFN_UNENCODABLE, temp_dir) |
There was a problem hiding this comment.
Oh, sorry for this terrible rebase operation, I use a new PR to replace it.
Automerge-Triggered-By: @tiran
* Add example on lazy imports * Use four spaces for indentation * change to console
The phrase "At any time during execution," was repeated twice. Automerge-Triggered-By: @Mariatta
…or (pythonGH-21474) #msg373510 [bpo-32528]()/python#13528 changed `asyncio.CancelledError` such that it no longer inherits from `concurrent.futures.CancelledError`. As this affects existing code, specifically when catching the latter instead of the former in exception handling, it should be documented in the "What's new in 3.8?" document. Automerge-Triggered-By: @1st1
…using recv_into instead of recv (python#21442) * bpo-41273: Proactor transport read loop to use recv_into By using recv_into instead of recv we do not allocate a new buffer each time _loop_reading calls recv. This betters performance for any stream using proactor (basically any asyncio stream on windows). * bpo-41273: Double proactor read transport buffer size By doubling the read buffer size we get better performance.
Avoid infinite loop when reading specially crafted TAR files using the tarfile module (CVE-2019-20907).
Move definition of UNUSED from modified headers of libmpdec to _decimal.c itself. This makes the vendored source closer to the standalone library and fixes build with --with-system-libmpdec. Tested to build fine with either system libmpdec or the vendored one.
…thonGH-21718) regrtest_unraisable_hook() temporarily replaces sys.stderr with sys.__stderr__ to help to display errors when a test captures stderr.
incr cannot be larger than INT_MAX: downcast to int explicitly.
On Windows, fix asyncio recv_into() return value when the socket/pipe is closed (BrokenPipeError): return 0 rather than an empty byte string (b'').
…ythonGH-17536) Co-authored-by: Jeffrey Kintscher <websurfer@surf2c.net>
shihai1991
requested review from
1st1,
abalkin,
asvetlov,
ethanfurman,
ezio-melotti,
gpshead,
gvanrossum,
ilevkivskyi,
lysnikolaou,
methane,
pablogsal,
pganssle,
rhettinger,
skrah,
terryjreedy,
tiran,
vsajip and
a team
as code owners
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). CLA MissingOur records indicate the following people have not signed the CLA: For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. If you have recently signed the CLA, please wait at least one business day You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use test helpers in the following test cases:
https://bugs.python.org/issue40275