bpo-20175: Convert Modules/_multiprocessing to the Argument Clinic #14245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serhiy-storchaka
requested changes
Jul 10, 2020
| Py_END_ALLOW_THREADS | ||
|
|
||
| PyBuffer_Release(&buf); | ||
| PyBuffer_Release(buf); |
Modules/_multiprocessing/semaphore.c
Outdated
| /*[clinic input] | ||
| _multiprocessing.SemLock.acquire | ||
|
|
||
| block as blocking: int = 1 |
There was a problem hiding this comment.
Suggested change
| block as blocking: int = 1 | |
| block as blocking: bool(accept={int}) = True |
Modules/_multiprocessing/semaphore.c
Outdated
| block as blocking: int = 1 | ||
| timeout as timeout_obj: object = None | ||
|
|
||
| acquire the semaphore/lock |
There was a problem hiding this comment.
Suggested change
| acquire the semaphore/lock | |
| Acquire the semaphore/lock. |
Modules/_multiprocessing/semaphore.c
Outdated
| /*[clinic input] | ||
| _multiprocessing.SemLock.release | ||
|
|
||
| release the semaphore/lock |
There was a problem hiding this comment.
Suggested change
| release the semaphore/lock | |
| Release the semaphore/lock. |
Modules/_multiprocessing/semaphore.c
Outdated
| value: int | ||
| maxvalue: int | ||
| name: str | ||
| unlink: int |
There was a problem hiding this comment.
Suggested change
| unlink: int | |
| unlink: bool(accept={int}) |
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
…rocessing-Argument-Clinic
arun-mani-j
pushed a commit
to arun-mani-j/cpython
that referenced
this pull request
Jul 21, 2020
shihai1991
pushed a commit
to shihai1991/cpython
that referenced
this pull request
Aug 4, 2020
shihai1991
pushed a commit
to shihai1991/cpython
that referenced
this pull request
Aug 20, 2020
xzy3
pushed a commit
to xzy3/cpython
that referenced
this pull request
Oct 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue20175