-
-
Notifications
You must be signed in to change notification settings - Fork 31.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-20181: Convert the readline module to the Argument Clinic #14326
bpo-20181: Convert the readline module to the Argument Clinic #14326
Conversation
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
…e-module-Argument-Clinic
I have made the requested changes; please review again. |
Thanks for making the requested changes! @serhiy-storchaka: please review the changes made to this pull request. |
Modules/readline.c
Outdated
|
||
/* Get the ending index for the scope of the tab-completion */ | ||
get the ending index of the completion scope |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix also other docstrings.
get the ending index of the completion scope | |
Get the ending index of the completion scope. |
Modules/readline.c
Outdated
|
||
Returns current completer function. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe use "get" for uniformity with other functions?
At least "return" is more preferable than "returns".
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
👍 |
@serhiy-storchaka: Please replace |
|
https://bugs.python.org/issue20181