bpo-30668: add missing word in license.rst #13115
Conversation
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Our records indicate we have not received your CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. If you have recently signed the CLA, please wait at least one business day You can check yourself to see if the CLA has been received. Thanks again for your contribution, we look forward to reviewing it! |
|
/cc @matrixise |
Doc/license.rst
Outdated
| @@ -561,7 +561,7 @@ SipHash24 | |||
| --------- | |||
|
|
|||
| The file :file:`Python/pyhash.c` contains Marek Majkowski' implementation of | |||
| Dan Bernstein's SipHash24 algorithm. The contains the following note:: | |||
| Dan Bernstein's SipHash24 algorithm. The module contains the following note:: | |||
There was a problem hiding this comment.
Could I suggest to use this sentence.
It contains ...
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
Thanks @treebee for the PR, and @matrixise for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7. |
(cherry picked from commit 4920c09) Co-authored-by: Patrick Mühlbauer <tmuxbiene@googlemail.com>
|
GH-13126 is a backport of this pull request to the 3.7 branch. |
|
Congratulation for your merge. Have a nice day and thank you a lot for your contribution. |
* master: (1204 commits) bpo-31855: unittest.mock.mock_open() results now respects the argument of read([size]) (pythonGH-11521) Forbid creating of stream objects outside of asyncio (python#13101) bpo-35925: Skip SSL tests that fail due to weak external certs. (pythonGH-13124) Fix rst formatting for several links in ssl documentation (pythonGH-13133) bpo-36542: Allow to overwrite the signature for Python functions. (pythonGH-12705) bpo-36793: Remove unneeded __str__ definitions. (pythonGH-13081) bpo-36766: Typos in docs and code comments (pythonGH-13116) bpo-36275: enhance documentation for venv.create() (pythonGH-13114) Clarify the download unit in the download section (pythonGH-13122) bpo-30668: add missing word in license.rst (pythonGH-13115) Unroll import-team in CODEOWNERS (python#13118) bpo-36594: Fix incorrect use of %p in format strings (pythonGH-12769) bpo-36798: Updating f-string docs for := use case (pythonGH-13107) Update wsgiref.rst (python#10488) Doc/c-api/exceptions.rst: fix grammar (python#12091) bpo-36811: Fix a C compiler warning in _elementtree.c. (pythonGH-13109) Only count number of members once (python#12691) bpo-16024: Doc cleanup regarding path_fd, dir_fd, follow_symlinks (pythonGH-5505) bpo-36791: Safer detection of integer overflow in sum(). (pythonGH-13080) bpo-33530: Implement Happy Eyeballs in asyncio, v2 (pythonGH-7237) ...
https://bugs.python.org/issue30668