Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-36766: Typos in docs and code comments #13116

Merged
merged 2 commits into from
May 6, 2019
Merged

bpo-36766: Typos in docs and code comments #13116

merged 2 commits into from
May 6, 2019

Conversation

GiantRobato
Copy link
Contributor

@GiantRobato GiantRobato commented May 6, 2019 •
edited by bedevere-bot
Loading

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Our records indicate we have not received your CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

ericvsmith
ericvsmith approved these changes May 6, 2019
View reviewed changes
Copy link
Member

@ericvsmith ericvsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look okay to me.

tirkarthi
tirkarthi approved these changes May 6, 2019
View reviewed changes
Copy link
Member

@tirkarthi tirkarthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. IMO, code comments are also worth fixing. I will leave it to reviewer on the same. Thank you for the contribution :)

@matrixise matrixise merged commit 9646630 into python:master May 6, 2019
@miss-islington
Copy link
Contributor

Thanks @penguindustin for the PR, and @matrixise for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @penguindustin and @matrixise, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 964663089547ca110199e23867b46b07ff4be88c 3.7

GiantRobato added a commit to GiantRobato/cpython that referenced this pull request May 6, 2019
@GiantRobato
[3.7] bpo-36766: Typos in docs and code comments (pythonGH-13116).
5e90673 
(cherry picked from commit 9646630)

Co-authored-by: penguindustin <penguindustin@gmail.com>
@bedevere-bot
Copy link

GH-13136 is a backport of this pull request to the 3.7 branch.

@matrixise
Copy link
Member

@terryjreedy keep me informed when I can close the associated PRs and the issue.

Thank you so much.

miss-islington pushed a commit that referenced this pull request May 6, 2019
@GiantRobato @miss-islington
[3.7] bpo-36766: Typos in docs and code comments (GH-13116). (GH-13136)
b2d29bf 
(cherry picked from commit 9646630)

Co-authored-by: penguindustin <penguindustin@gmail.com>





https://bugs.python.org/issue36766
@matrixise
Copy link
Member

@terryjreedy I have merged the backport for 3.7.

@terryjreedy
Copy link
Member

A PR is permanently closed when merged. The issue can be closed when the last merge is done (easy to forget). I did it since I wanted to leave a thank you message anyway.

CuriousLearner added a commit to CuriousLearner/cpython that referenced this pull request May 7, 2019
@CuriousLearner
Merge branch 'master' into fix-25439
2cb5fd7 
* master: (1204 commits)
  bpo-31855: unittest.mock.mock_open() results now respects the argument of read([size]) (pythonGH-11521)
  Forbid creating of stream objects outside of asyncio (python#13101)
  bpo-35925: Skip SSL tests that fail due to weak external certs. (pythonGH-13124)
  Fix rst formatting for several links in ssl documentation (pythonGH-13133)
  bpo-36542: Allow to overwrite the signature for Python functions. (pythonGH-12705)
  bpo-36793: Remove unneeded __str__ definitions. (pythonGH-13081)
  bpo-36766: Typos in docs and code comments (pythonGH-13116)
  bpo-36275: enhance documentation for venv.create() (pythonGH-13114)
  Clarify the download unit in the download section (pythonGH-13122)
  bpo-30668: add missing word in license.rst (pythonGH-13115)
  Unroll import-team in CODEOWNERS (python#13118)
  bpo-36594: Fix incorrect use of %p in format strings (pythonGH-12769)
  bpo-36798: Updating f-string docs for := use case (pythonGH-13107)
  Update wsgiref.rst (python#10488)
  Doc/c-api/exceptions.rst: fix grammar (python#12091)
  bpo-36811: Fix a C compiler warning in _elementtree.c. (pythonGH-13109)
  Only count number of members once (python#12691)
  bpo-16024: Doc cleanup regarding path_fd, dir_fd, follow_symlinks (pythonGH-5505)
  bpo-36791: Safer detection of integer overflow in sum(). (pythonGH-13080)
  bpo-33530: Implement Happy Eyeballs in asyncio, v2 (pythonGH-7237)
  ...
@tirkarthi tirkarthi mentioned this pull request May 16, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericvsmith ericvsmith ericvsmith approved these changes

@tirkarthi tirkarthi tirkarthi approved these changes

@rhettinger rhettinger Awaiting requested review from rhettinger

@terryjreedy terryjreedy Awaiting requested review from terryjreedy

Assignees

@matrixise matrixise

Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@GiantRobato @the-knights-who-say-ni @miss-islington @bedevere-bot @matrixise @terryjreedy @ericvsmith @tirkarthi