Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-36542: Allow to overwrite the signature for Python functions. #12705

Merged
merged 1 commit into from
May 6, 2019
Merged

bpo-36542: Allow to overwrite the signature for Python functions. #12705

merged 1 commit into from
May 6, 2019

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Apr 6, 2019 •
edited by bedevere-bot
Loading

@serhiy-storchaka serhiy-storchaka added the type-feature A feature request or enhancement label Apr 6, 2019
@tirkarthi
Copy link
Member

I am not sure if it's related but seems there is some issue with bedevere? python/bedevere#162

gvanrossum
gvanrossum approved these changes Apr 6, 2019
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like a good idea.

Can you point me to docs that explain the significance of the $ in $self and $cls? (I can guess this is to mark that function parameter as not being part of the method signature, but until last week I had never heard of this convention. :-)

@serhiy-storchaka
Copy link
Member Author

Can you point me to docs that explain the significance of the $ in $self and $cls?

Seems it is not documented ☹️ . It is only explained in comments and docstrings of private functions in clinic.py and inspect.py.

@serhiy-storchaka serhiy-storchaka merged commit d53cf99 into python:master May 6, 2019
@serhiy-storchaka serhiy-storchaka deleted the python-function-text-signature branch May 6, 2019 19:40
CuriousLearner added a commit to CuriousLearner/cpython that referenced this pull request May 7, 2019
@CuriousLearner
Merge branch 'master' into fix-25439
2cb5fd7 
* master: (1204 commits)
  bpo-31855: unittest.mock.mock_open() results now respects the argument of read([size]) (pythonGH-11521)
  Forbid creating of stream objects outside of asyncio (python#13101)
  bpo-35925: Skip SSL tests that fail due to weak external certs. (pythonGH-13124)
  Fix rst formatting for several links in ssl documentation (pythonGH-13133)
  bpo-36542: Allow to overwrite the signature for Python functions. (pythonGH-12705)
  bpo-36793: Remove unneeded __str__ definitions. (pythonGH-13081)
  bpo-36766: Typos in docs and code comments (pythonGH-13116)
  bpo-36275: enhance documentation for venv.create() (pythonGH-13114)
  Clarify the download unit in the download section (pythonGH-13122)
  bpo-30668: add missing word in license.rst (pythonGH-13115)
  Unroll import-team in CODEOWNERS (python#13118)
  bpo-36594: Fix incorrect use of %p in format strings (pythonGH-12769)
  bpo-36798: Updating f-string docs for := use case (pythonGH-13107)
  Update wsgiref.rst (python#10488)
  Doc/c-api/exceptions.rst: fix grammar (python#12091)
  bpo-36811: Fix a C compiler warning in _elementtree.c. (pythonGH-13109)
  Only count number of members once (python#12691)
  bpo-16024: Doc cleanup regarding path_fd, dir_fd, follow_symlinks (pythonGH-5505)
  bpo-36791: Safer detection of integer overflow in sum(). (pythonGH-13080)
  bpo-33530: Implement Happy Eyeballs in asyncio, v2 (pythonGH-7237)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

@1st1 1st1 Awaiting requested review from 1st1

@rhettinger rhettinger Awaiting requested review from rhettinger

Assignees
No one assigned
Labels
type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@serhiy-storchaka @tirkarthi @gvanrossum @the-knights-who-say-ni @bedevere-bot