Skip to content

[3.12] GH-113516: don't set LDSHARED when building for WASI (GH-115495) #115496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 15, 2024
Merged

[3.12] GH-113516: don't set LDSHARED when building for WASI (GH-115495) #115496

merged 1 commit into from
Feb 15, 2024

Conversation

brettcannon
Copy link
Member

@brettcannon brettcannon commented Feb 15, 2024 •
edited by bedevere-app bot
Loading

@brettcannon brettcannon self-assigned this Feb 15, 2024
This was referenced Feb 15, 2024
Merged
Closed
@brettcannon brettcannon added the needs backport to 3.11 only security fixes label Feb 15, 2024
@brettcannon
Copy link
Member Author

!buildbot wasi

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @brettcannon for commit 51ae736 🤖

The command will test the builders whose names match following regular expression: wasi

The builders matched are:

  • wasm32-wasi Non-Debug PR
  • wasm32 WASI 8Core PR
  • wasm32-wasi PR

@brettcannon brettcannon enabled auto-merge (squash) February 15, 2024 01:04
@brettcannon brettcannon merged commit 0e4f73b into python:3.12 Feb 15, 2024
@brettcannon brettcannon deleted the backport-115495 branch February 15, 2024 01:19
@miss-islington-app
Copy link

Thanks @brettcannon for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 15, 2024
@brettcannon @miss-islington
[3.12] pythonGH-113516: don't set LDSHARED when building for WASI (p…
7ef793b 
…ythonGH-115495) (pythonGH-115496)

(cherry picked from commit 0e4f73b)

Co-authored-by: Brett Cannon <brett@python.org>
@bedevere-app
Copy link

bedevere-app bot commented Feb 15, 2024

GH-115497 is a backport of this pull request to the 3.11 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.11 only security fixes label Feb 15, 2024
brettcannon added a commit that referenced this pull request Feb 15, 2024
@miss-islington @brettcannon
[3.11] [3.12] GH-113516: don't set LDSHARED when building for WASI (G…
9bb3f56 
…H-115495) (GH-115496) (GH-115497)

[3.12] GH-113516: don't set `LDSHARED` when building for WASI (GH-115495) (GH-115496)
(cherry picked from commit 0e4f73b)

Co-authored-by: Brett Cannon <brett@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@brettcannon brettcannon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brettcannon @bedevere-bot