Skip to content

GH-113516: don't set LDSHARED when building for WASI #115495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 15, 2024
Merged

GH-113516: don't set LDSHARED when building for WASI #115495

merged 2 commits into from
Feb 15, 2024

Conversation

brettcannon
Copy link
Member

@brettcannon brettcannon commented Feb 15, 2024 •
edited by bedevere-app bot
Loading

@brettcannon brettcannon self-assigned this Feb 15, 2024
@bedevere-app bedevere-app bot mentioned this pull request Feb 15, 2024
Closed
brettcannon
brettcannon commented Feb 15, 2024
View reviewed changes
Copy link
Member Author

@brettcannon brettcannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

!buildbot wasi

@brettcannon
Copy link
Member Author

!buildbot wasi

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @brettcannon for commit 1637931 🤖

The command will test the builders whose names match following regular expression: wasi

The builders matched are:

  • wasm32-wasi Non-Debug PR
  • wasm32 WASI 8Core PR
  • wasm32-wasi PR

@brettcannon brettcannon enabled auto-merge (squash) February 15, 2024 00:35
@brettcannon brettcannon added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Feb 15, 2024
@brettcannon brettcannon merged commit 18343c0 into python:main Feb 15, 2024
@brettcannon brettcannon deleted the wasi-do-not-set-ldshared branch February 15, 2024 00:51
@miss-islington-app
Copy link

Thanks @brettcannon for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @brettcannon, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 18343c09856fcac11f813a5a59ffe3a35928c0cc 3.12

@miss-islington-app
Copy link

Sorry, @brettcannon, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 18343c09856fcac11f813a5a59ffe3a35928c0cc 3.11

@bedevere-app
Copy link

bedevere-app bot commented Feb 15, 2024

GH-115496 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Feb 15, 2024
brettcannon added a commit to brettcannon/cpython that referenced this pull request Feb 15, 2024
@brettcannon
[3.12] pythonGH-113516: don't set LDSHARED when building for WASI (p…
51ae736 
…ythonGH-115495)
brettcannon added a commit that referenced this pull request Feb 15, 2024
@brettcannon
[3.12] GH-113516: don't set LDSHARED when building for WASI (GH-115495
0e4f73b 
) (GH-115496)
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 15, 2024
@brettcannon @miss-islington
[3.12] pythonGH-113516: don't set LDSHARED when building for WASI (p…
7ef793b 
…ythonGH-115495) (pythonGH-115496)

(cherry picked from commit 0e4f73b)

Co-authored-by: Brett Cannon <brett@python.org>
brettcannon added a commit that referenced this pull request Feb 15, 2024
@miss-islington @brettcannon
[3.11] [3.12] GH-113516: don't set LDSHARED when building for WASI (G…
9bb3f56 
…H-115495) (GH-115496) (GH-115497)

[3.12] GH-113516: don't set `LDSHARED` when building for WASI (GH-115495) (GH-115496)
(cherry picked from commit 0e4f73b)

Co-authored-by: Brett Cannon <brett@python.org>
@terryjreedy terryjreedy removed the needs backport to 3.11 only security fixes label Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@brettcannon brettcannon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brettcannon @bedevere-bot @terryjreedy