Build fails with WASI SDK 21

[proman2019]

Bug report

Bug description:

Hello!
when executing
python3 Tools/wasm/wasi.py make-host
on ubuntu 22.04 with wasi-ld version: LLD 17.0.6 (tried earlier versions too)
Errors are as follows:

/opt/wasi-sdk/bin/wasm-ld   -z stack-size=524288 -Wl,--stack-first -Wl,--initial-memory=10485760   Modules/_testimportmultiple.o   -o Modules/_testimportmultiple.cpython-313d-wasm32-wasi.so
/opt/wasi-sdk/bin/wasm-ld   -z stack-size=524288 -Wl,--stack-first -Wl,--initial-memory=10485760   Modules/_testmultiphase.o   -o Modules/_testmultiphase.cpython-313d-wasm32-wasi.so
/opt/wasi-sdk/bin/wasm-ld   -z stack-size=524288 -Wl,--stack-first -Wl,--initial-memory=10485760   Modules/_testsinglephase.o   -o Modules/_testsinglephase.cpython-313d-wasm32-wasi.so
/opt/wasi-sdk/bin/wasm-ld   -z stack-size=524288 -Wl,--stack-first -Wl,--initial-memory=10485760   Modules/xxlimited.o   -o Modules/xxlimited.cpython-313d-wasm32-wasi.so
/opt/wasi-sdk/bin/wasm-ld   -z stack-size=524288 -Wl,--stack-first -Wl,--initial-memory=10485760   Modules/xxlimited_35.o   -o Modules/xxlimited_35.cpython-313d-wasm32-wasi.so
wasm-ld: error: unknown argument: -Wl,--stack-first
wasm-ld: error: unknown argument: -Wl,--stack-first
wasm-ld: error: unknown argument: -Wl,--initial-memory=10485760
wasm-ld: error: unknown argument: -Wl,--initial-memory=10485760
wasm-ld: error: unknown argument: -Wl,--stack-first
wasm-ld: error: unknown argument: -Wl,--initial-memory=10485760
wasm-ld: error: unknown argument: -Wl,--stack-first
wasm-ld: error: unknown argument: -Wl,--initial-memory=10485760
make: *** [Makefile:3134: Modules/_testimportmultiple.cpython-313d-wasm32-wasi.so] Error 1

if "-Wl" flag removed then clang compiler fails.

CPython versions tested on:

3.13

Operating systems tested on:

Linux

Linked PRs

• GH-113516: don't set LDSHARED when building for WASI #115495
• [3.12] GH-113516: don't set LDSHARED when building for WASI (GH-115495) #115496
• [3.11] [3.12] GH-113516: don't set LDSHARED when building for WASI (GH-115495) (GH-115496) #115497

[brettcannon]

What version of the WASI-SDK did you use?

[proman2019]

Hi - I believe I was failing with wasi-sdk-20. It builds fine for wasi-sdk 16. From: Brett Cannon ***@***.***> Sent: Wednesday, January 3, 2024 6:05 PM To: python/cpython ***@***.***> Cc: Romanczyk, Piotr ***@***.***>; Author ***@***.***> Subject: [External] Re: [python/cpython] wasi build appears to fail (Issue #113516) What version of the WASI-SDK did you use? - Reply to this email directly, view it on GitHub<#113516 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AMBG4R5W4VEQWQCU6ZJIGMDYMXP2NAVCNFSM6AAAAABBEQFICCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZWGA4DSMZQGA>. You are receiving this because you authored the thread.Message ID: ***@***.******@***.***>> **** Resideo WARNING: This email was sent from outside of Resideo and the sender cannot be verified. Use CAUTION before opening file attachments, links, or replying to the email. For additional information please contact the Resideo Service Desk ****

[brettcannon]

It builds fine for me under WASI-SDK 20.

Can you share all 4 commands you used w/ wasi.py? Do you get a different result if you use wasi.py build?

[proman2019]

Sorry for the delay... I've used exact same commands as listed on ./Tools/wasm README.md for WASI builds: python Tools/wasm/wasi.py configure-build-python python Tools/wasm/wasi.py make-build-python python Tools/wasm/wasi.py configure-host python Tools/wasm/wasi.py make-host I am a bit confused about the wasi-sdk versions - when I get wasi-sdk-16 tagged source I get this: ./wasi-ld -version LLD 14.0.4 The above version builds just fine from cpython main I thought it was v 20 failing and I can't tell exactly which wasi-sdk version is the one failing in my setup but the one that fails has this version of lld installed: ./wasi-ld -version LLD 17.0.6 Hope that helps From: Brett Cannon ***@***.***> Sent: Thursday, January 4, 2024 1:29 PM To: python/cpython ***@***.***> Cc: Romanczyk, Piotr ***@***.***>; Author ***@***.***> Subject: [External] Re: [python/cpython] wasi build appears to fail (Issue #113516) It builds fine for me under WASI-SDK 20. Can you share all 4 commands you used w/ wasi.py? Do you get a different result if you use wasi.py build? - Reply to this email directly, view it on GitHub<#113516 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AMBG4R5S7YJEPGJKURS22FDYM3YE7AVCNFSM6AAAAABBEQFICCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZXGU3DSNZSGQ>. You are receiving this because you authored the thread.Message ID: ***@***.******@***.***>> **** Resideo WARNING: This email was sent from outside of Resideo and the sender cannot be verified. Use CAUTION before opening file attachments, links, or replying to the email. For additional information please contact the Resideo Service Desk ****

[brettcannon]

Unfortunately w/o knowing what WASI-SDK version is having issues I don't know how to help since I don't have these failures under WASI-SDK 20. If it's WASI-SDK 21 (which we have not tried to support yet), then that might be the cause, but then that means they may have broken something.

[brettcannon]

I opened WebAssembly/wasi-sdk#372 to see if there's an easy way to find this out.

[proman2019]

Understood - no problem. I've got it to build and working with wasi-sdk-16.0 - I will try wasi-sdk-20.0 later this week. Thanks! From: Brett Cannon ***@***.***> Sent: Monday, January 8, 2024 2:54 PM To: python/cpython ***@***.***> Cc: Romanczyk, Piotr ***@***.***>; Author ***@***.***> Subject: [External] Re: [python/cpython] wasi build appears to fail (Issue #113516) Unfortunately w/o knowing what WASI-SDK version is having issues I don't know how to help since I don't have these failures under WASI-SDK 20. If it's WASI-SDK 21 (which we have not tried to support yet), then that might be the cause, but then that means they may have broken something. - Reply to this email directly, view it on GitHub<#113516 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AMBG4R53OOAI34QHAPIP6Y3YNRFEPAVCNFSM6AAAAABBEQFICCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBRG4ZDQNJSGQ>. You are receiving this because you authored the thread.Message ID: ***@***.******@***.***>> **** Resideo WARNING: This email was sent from outside of Resideo and the sender cannot be verified. Use CAUTION before opening file attachments, links, or replying to the email. For additional information please contact the Resideo Service Desk ****

[proman2019]

Sounds good! Thanks. From: Brett Cannon ***@***.***> Sent: Monday, January 8, 2024 2:57 PM To: python/cpython ***@***.***> Cc: Romanczyk, Piotr ***@***.***>; Author ***@***.***> Subject: [External] Re: [python/cpython] wasi build appears to fail (Issue #113516) I opened WebAssembly/wasi-sdk#372<WebAssembly/wasi-sdk#372> to see if there's an easy way to find this out. - Reply to this email directly, view it on GitHub<#113516 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AMBG4R6E32SP5HZO6PA75U3YNRFPXAVCNFSM6AAAAABBEQFICCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBRG4ZTEMRYGY>. You are receiving this because you authored the thread.Message ID: ***@***.******@***.***>> **** Resideo WARNING: This email was sent from outside of Resideo and the sender cannot be verified. Use CAUTION before opening file attachments, links, or replying to the email. For additional information please contact the Resideo Service Desk ****

[encukou]

I will close the issue. If you have more information, please comment here or file a new one.

[kushaldas]

Fails to build using wasi-sdk-21.

/opt/wasi-sdk/bin/clang -c -fno-strict-overflow -Wsign-compare -g -Og -Wall    -std=c11 -Wextra -Wno-unused-parameter -Wno-int-conversion -Wno-missing-field-initializers -Wstrict-prototypes -Werror=implicit-function-declaration -fvisibility=hidden  -I../../Include/internal -I../../Include/internal/mimalloc -IObjects -IInclude -IPython -I. -I../../Include    -DPy_BUILD_CORE -o Python/frozen.o ../../Python/frozen.c
_PYTHON_HOSTRUNNER='/home/kdas/.wasmtime/bin/wasmtime run --wasm max-wasm-stack=8388608 --wasm threads=y --wasi threads=y --dir /home/kdas/code/cpython::/ --env PYTHONPATH=/cross-build/wasm32-wasi/build/lib.wasi-wasm32-3.13-pydebug' _PYTHON_PROJECT_BASE=/home/kdas/code/cpython/cross-build/wasm32-wasi _PYTHON_HOST_PLATFORM=wasi-wasm32 PYTHONPATH=/home/kdas/code/cpython/cross-build/wasm32-wasi/build/lib.wasi-wasm32-3.13-pydebug:../../Lib _PYTHON_SYSCONFIGDATA_NAME=_sysconfigdata_d_wasi_wasm32-wasi /home/kdas/code/cpython/cross-build/build/python -c 'import sys ; from sysconfig import get_platform ; print("%s-%d.%d" % (get_platform(), *sys.version_info[:2]))' >platform
/opt/wasi-sdk/bin/wasm-ld   -z stack-size=524288 -Wl,--stack-first -Wl,--initial-memory=10485760   Modules/_testimportmultiple.o   -o Modules/_testimportmultiple.cpython-313d-wasm32-wasi.so
wasm-ld: error: unknown argument: -Wl,--stack-first
wasm-ld: error: unknown argument: -Wl,--initial-memory=10485760
make: *** [Makefile:3183: Modules/_testimportmultiple.cpython-313d-wasm32-wasi.so] Error 1
make: *** Waiting for unfinished jobs....