Team 18 #7

katlyn · 2018-03-23T00:55:46Z

Woot

Fix Pipfile dependencies

Add a print statement so we can open our pull request

Exclude virtualenv from Flake8 linting. Again.

double spaces hurt me

Allows you to get human readable level of danger

lemonsaurus

get_danger is both a fun idea, and particularly well written. rattle.py should match this level of quality. Docstrings, type hinting and some more comments would help a lot.

lemonsaurus · 2018-03-24T02:10:57Z

tools/rattle.py

+        h = len(otherword) - len(word)
+        word += '~' * h
+        return word
+    '''


docstring before helper functions please.

lemonsaurus · 2018-03-24T02:12:00Z

tools/rattle.py

@@ -0,0 +1,45 @@
+# rattle - easy word similarity detection
+def check_word(word, wordset, threshold=0.8):
+    def get_shortest(x, y):


These helper functions should also have docstrings.

lemonsaurus · 2018-03-24T02:12:48Z

tools/rattle.py

+        length_diff_multiplier = 1.08
+        mp_count = 1
+        shorter = ''
+        if shortest == word:


This function desperately needs block comments. runs a bit hot.

[UPDATE] Ignored a silly rule from flake8.

…rection

@hargoniX

ok @hargoniX

…d fixed a core issue with the command.

gdude2002 · 2018-03-25T11:11:12Z

bot/cogs/snakes.py

 from discord.ext.commands import AutoShardedBot, Context, command

+from ..tools import rattle


Please no relative imports.

gdude2002 · 2018-03-25T11:12:00Z

bot/cogs/snakes.py

 log = logging.getLogger(__name__)
+db = load(open('bot/cogs/snek.pickledb', 'rb'))  # are we going to move this db elsewhere?
+SNAKE_NAMES = db.keys()  # make a list of common names for snakes, used for random snake and autocorrect
+DEBUG = True


Hardcoded debug mode?

gdude2002 · 2018-03-25T11:13:31Z

bot/cogs/snakes.py

+        embed.set_footer(text="Information from Wikipedia and snakedatabase.org. Information has been " \
+                         "automatically fetched and may not be accurate.")
+        await ctx.send(embed=embed)
+
    # Any additional commands can be placed here. Be creative, but keep it to a reasonable amount!


With 12 hours to go, you have no extra functionality!

Because we need more functionality .

Debug is now based on the presence of the environment variable SNAKES_DEBUG

Zwork101

Very few issues, and nothing major. You did a great job documenting the project making your code clear. Can't wait to see what you'll make next Jam!

Zwork101 · 2018-04-03T20:28:05Z

bot/cogs/events.py

+            parent = command.parent
+
+        if parent and command:
+            help_command = (self.bot.get_command("help"), parent.name, command.name)


Including the ( and ) is unnecessary, you can accomplish the same feat with simply

help_command = self.bot.get_command("help"), parent.name, command.name

Zwork101 · 2018-04-03T20:32:14Z

bot/cogs/events.py

+                f"Sorry, an unexpected error occurred. Please let us know!\n\n```{e}```"
+            )
+            raise e.original
+        log.error(f"COMMAND ERROR: '{e}'")


This isn't logged if a non-expected CommandInvokeError happens. You could either wrap the ifs in a try - finally block, however just logging the error before you raise it would be fine.

Zwork101 · 2018-04-03T20:39:02Z

bot/cogs/events.py

+
+        log.debug(f"{before.display_name} roles changing from {before_role_names} to {after_role_names}")
+
+        if OWNER_ROLE in role_ids:


You do this process twice, you should make a function that does this. Don't repeat yourself 😉

Zwork101 · 2018-04-03T20:40:37Z

bot/cogs/snakes.py

+DEBUG = environ.get('SNAKES_DEBUG', None)
+dprint = print if DEBUG else lambda *a, **k: None  # -1 index is used for easy temp debug hardcode
+
+SNEK_FACTS = json.loads(open('bot/cogs/facts.json', 'r', encoding='utf-8').read())


You never close this file, or the snek,picklebd file.

Zwork101 · 2018-04-03T20:42:03Z

bot/cogs/snakes.py

+class NoGuessError(Exception):
+    def __init__(self, message='', debugdata=None):
+        self.message = message
+        self.debugdata = debugdata


This is python, let's use _ where there should be a space:

class NoGuessError(Exception): def __init__(self, message='', debug_data=None): self.message = message self.debug_data = debug_data

Zwork101 · 2018-04-03T20:46:24Z

bot/cogs/snakes.py

+            '💀💀': 'Venomous, harmful',
+            '💀💀💀': 'Venomous, dangerous',
+            '💀💀💀💀': 'Venomous, very dangerous',
+            '💀💀💀💀💀': 'Venomous, extremely dangerous.'


Could this be moved into a json file, that's already loaded?

Zwork101 · 2018-04-03T20:47:37Z

bot/cogs/snakes.py

+            "Tumblr_m2g660GN9z1qcwgmzo1_1280.png/revision/latest?cb=20120611212456"
+            scient = 'Chironex fleckeri'
+            length = '9.8 ft'
+            custom = True


These 3 sneks fall under the same issue as the danger dict. Move this data into a json file!

katlyn added 2 commits March 22, 2018 18:32

Merge pull request #1 from discord-python/master

826e563

Fix Pipfile dependencies

Sneks

03722c4

Add a print statement so we can open our pull request

gdude2002 changed the title ~~WIP Team 18~~ Team 18 Mar 23, 2018

katlyn and others added 8 commits March 22, 2018 19:23

Merge pull request #2 from discord-python/master

8705049

Exclude virtualenv from Flake8 linting. Again.

Added a word similarity detector.

217839e

Add events.py to account for bad commands

6b44d19

Silenced the screams of pain from flake8

99016fb

Removed extra space from line 41

41b5c5c

double spaces hurt me

Added a newline

95260a5

Add get_danger utility function

300dad1

Allows you to get human readable level of danger

Add get_danger docstring

91cde5d

lemonsaurus reviewed Mar 24, 2018

View reviewed changes

katlyn and others added 15 commits March 23, 2018 22:59

Get ready for sneks

2055ced

Line length fix

c3cf9a5

Documented rattle.py

75f0154

Merge pull request #3 from discord-python/master

1bde63d

[UPDATE] Ignored a silly rule from flake8.

Fix variable naming

3ac3b81

Added the get_snek core function, includes misspell detection and cor…

8f74f6d

…rection

Added the snek database

21a0e5d

ok @hargoniX

Fix some import errors

e927865

Added some debugging info, as well as a catch if spellcheck fails, an…

c761b7b

…d fixed a core issue with the command.

Git screwed me... grrr

40ecb63

how could I be so stupid?

2468e2b

Fix embed building

fa260c6

Added an extra notice

68eaebd

I am so incredibly dense

aecd752

Reduced similarity threshold

6c80c67

gdude2002 suggested changes Mar 25, 2018

View reviewed changes

katlyn added 2 commits March 25, 2018 10:15

snek say

3fc366b

Because we need more functionality .

Fix flake8 not liking pickle

272a045

katlyn and others added 21 commits March 25, 2018 10:18

Fix whitespace

107af30

Fixed spellcheck, removed shoddy descriptions

b3d26ee

Fixed an error reeee

9d2efc1

Added some more info to the embed, fixed glaring issues

904d416

Updated docstrings for fix_margins

5f9db70

Fixed database probably, added some jokes

2837244

Fixed custom stuff

8feee93

Fix flake8 linting

4970c4f

Trying a cm fix

3641d1b

Add snek facts

d5fe34f

Flake8 line too long

1984019

Added a facts command.

6d6f404

Imported json...

67234de

Updated path I'm dumb

0b65319

Why do i keep doing this to myself

503a4c0

Removed debug hardcode

721b941

Debug is now based on the presence of the environment variable SNAKES_DEBUG

Renamed debug print to dprint

5def2bb

Added snek_pic command

a38d288

Ew fix

1f326ac

n-nani?!

fe8f102

Fixed multi-lines

0d78943

Zwork101 reviewed Apr 3, 2018

View reviewed changes

		from discord.ext.commands import AutoShardedBot, Context, command

		from ..tools import rattle


		log.debug(f"{before.display_name} roles changing from {before_role_names} to {after_role_names}")

		if OWNER_ROLE in role_ids:

Uh oh!

Team 18 #7

Are you sure you want to change the base?

Team 18 #7

Uh oh!

Conversation

katlyn commented Mar 23, 2018

Uh oh!

lemonsaurus left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Zwork101 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!