-
-
Notifications
You must be signed in to change notification settings - Fork 16
Team 23 #3
base: master
Are you sure you want to change the base?
Team 23 #3
Conversation
Exclude virtualenv from Flake8 linting. Again.
thank mr travis
because you can't zoom on thumbnails
Use image instead of thumbnail
bot/cogs/snakes.py
Outdated
|
||
The information includes the name of the snake, a picture of the snake, and various other pieces of info. | ||
What information you get for the snake is up to you. Be creative! | ||
async def get_snek(self, name: str = None) -> SnakeDef: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you guys are missing a docstring :P
bot/cogs/snakes.py
Outdated
|
||
@command() | ||
async def get(self, ctx: Context, name: str = None): | ||
""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also now missing a docstring. This one's important as it shows help text to the user.
Scrape data from ITIS database
(WIP) Snakes and Ladders
fixed snakeme, added hatching
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I honestly am having a hard time finding any faults with this. It's really exceptionally good work. There are some really fun ideas in here. The code style is, as far as I can tell, basically perfect. I wish I could give you a brutal review full of actionable suggestions, but, I'm sorry (or glad) to say that I cannot.
family="sneks-that-byte", | ||
genus="\"Programming Language\"", | ||
short_description="python is a language that you learn because tensorflow has an API for it", | ||
wiki_link="https://en.wikipedia.org/wiki/Pseudocode" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤣
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you document all your environment variables somewhere?
@gdude2002 done in readme ✔️ |
Also fixed an incorrect snake in the board file
delet print
- Add tool to fetch a collection of sneks on Wikipedia - Use pickle to store/load said list - Add exception for pickle in tox.ini
For your information, there is a continuation for this entry in a separate branch. I'm planning on bringing improvements to perlin-sneks and Snakes & Ladders |
Mate: @qrie (kel)
Setting up the environment was the hard part