Skip to content
This repository was archived by the owner on Mar 14, 2021. It is now read-only.

Team 23 #3

Open
wants to merge 75 commits into
base: master
Choose a base branch
from
Open

Team 23 #3

wants to merge 75 commits into from

Conversation

aramperes
Copy link

@aramperes aramperes commented Mar 23, 2018

Mate: @qrie (kel)

Setting up the environment was the hard part


The information includes the name of the snake, a picture of the snake, and various other pieces of info.
What information you get for the snake is up to you. Be creative!
async def get_snek(self, name: str = None) -> SnakeDef:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you guys are missing a docstring :P


@command()
async def get(self, ctx: Context, name: str = None):
"""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also now missing a docstring. This one's important as it shows help text to the user.

Copy link
Member

@lemonsaurus lemonsaurus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I honestly am having a hard time finding any faults with this. It's really exceptionally good work. There are some really fun ideas in here. The code style is, as far as I can tell, basically perfect. I wish I could give you a brutal review full of actionable suggestions, but, I'm sorry (or glad) to say that I cannot.

family="sneks-that-byte",
genus="\"Programming Language\"",
short_description="python is a language that you learn because tensorflow has an API for it",
wiki_link="https://en.wikipedia.org/wiki/Pseudocode"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤣

Copy link
Contributor

@gdude2002 gdude2002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you document all your environment variables somewhere?

@aramperes
Copy link
Author

@gdude2002 done in readme ✔️
@1mn means a lot, ty :D

@aramperes aramperes closed this Mar 27, 2018
@aramperes aramperes reopened this Mar 27, 2018
@aramperes
Copy link
Author

For your information, there is a continuation for this entry in a separate branch. I'm planning on bringing improvements to perlin-sneks and Snakes & Ladders

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants