This repository was archived by the owner on Mar 14, 2021. It is now read-only.
Team 7 #2
Open
Team 7 #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix Pipfile dependencies
Exclude virtualenv from Flake8 linting. Again.
|
No commits yet? Hmm. |
gdude2002
suggested changes
Mar 25, 2018
jb3
suggested changes
Mar 25, 2018
| """ | ||
|
|
||
|
|
||
| async def get_json(url): |
There was a problem hiding this comment.
Why not json.loads inside this function so that you don't have to repeat code in future usages of this function?
bot/cogs/snakes.py
Outdated
| if name in WikiListener.get_all_snek(): | ||
| return True | ||
| else: | ||
| return False | ||
|
|
||
| @command() | ||
| async def get(self, ctx: Context, name: str = None): |
There was a problem hiding this comment.
You should add some documentation to the command using docstrings.
@command
async def get(...):
"""Command info here"""
...
bot/cogs/snakes.py
Outdated
| This should make use of your `get_snek` method, using it to get information about a snake. This information | ||
| should be sent back to Discord in an embed. | ||
| quemoji = ['🇦', '🇧', '🇨', '🇩'] | ||
| question = ['Which snek is the sneakiest snek?', '🇦Cobra\n\n🇧Regular Snek\n\n🇨Python\n\n🇩<Cobra></Cobra>', '🇨'] |
There was a problem hiding this comment.
Any reason for Cobra being in < and >?
There was a problem hiding this comment.
No reason at all. I am still testing the features the questions will be in a seperate file. Probably json.
jb3
suggested changes
Mar 25, 2018
.vscode/settings.json
Outdated
| @@ -0,0 +1,6 @@ | |||
| { | |||
There was a problem hiding this comment.
Don't think this file should be here...
[UPDATE] Ignored a silly rule from flake8.
|
You code is failing to lint. Please see Travis for more information. |
lemonsaurus
pushed a commit
to python-discord/bot
that referenced
this pull request
May 10, 2018
…g. (#74) Original PR: python-discord/code-jam-1#2 Completes task: https://app.clickup.com/754996/757069/t/2ww7u
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.