Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typing: adding check and fixing #250

Merged
merged 13 commits into from
Oct 26, 2024
Merged

typing: adding check and fixing #250

merged 13 commits into from
Oct 26, 2024

Conversation

Borda
Copy link
Contributor

@Borda Borda commented Oct 23, 2024

reaction to #246 (comment)
so there are still a few typing issues to be fixed 🐰

will finish the test fixing after #248 and #249

@Borda Borda requested a review from shaypal5 as a code owner October 23, 2024 21:47
@Borda Borda marked this pull request as draft October 23, 2024 21:47
@Borda Borda marked this pull request as ready for review October 24, 2024 20:16
@Borda
Copy link
Contributor Author

Borda commented Oct 24, 2024

remaining:

FAILED tests/test_general.py::test_runtime_handling[pickle] - assert 3 == -1
 +  where 3 = <function test_runtime_handling.<locals>.fn_minus at 0x106041510>(1, 2)
 +    where <function test_runtime_handling.<locals>.fn_minus at 0x106041510> = <function cachier.<locals>._cachier_decorator at 0x106041240>(<function test_runtime_handling.<locals>.fn_minus at 0x106040a60>)
FAILED tests/test_general.py::test_partial_handling - assert 3 == -1
 +  where 3 = <function cachier.<locals>._cachier_decorator.<locals>.func_wrapper at 0x106042440>()
 +    where <function cachier.<locals>._cachier_decorator.<locals>.func_wrapper at 0x106042440> = <function cachier.<locals>._cachier_decorator at 0x1060423b0>(functools.partial(<function test_partial_handling.<locals>.fn_minus at 0x106042290>, 1))

@shaypal5
Copy link
Collaborator

Nice. The other two PRs are merged.
Should I release a version now, or wait for this PR?
@Borda

@Borda
Copy link
Contributor Author

Borda commented Oct 25, 2024

Nice. The other two PRs are merged. Should I release a version now, or wait for this PR?

@shaypal5 🐰 up to you but it shall be resolved now :)

Copy link
Collaborator

@shaypal5 shaypal5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work, as usual. :)

@shaypal5 shaypal5 merged commit 82d2341 into master Oct 26, 2024
33 checks passed
@shaypal5 shaypal5 deleted the ci/mypy branch October 26, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants