Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix reusing legacy pickle caches #249

Merged
merged 3 commits into from
Oct 25, 2024
Merged

fix reusing legacy pickle caches #249

merged 3 commits into from
Oct 25, 2024

Conversation

Borda
Copy link
Contributor

@Borda Borda commented Oct 23, 2024 •
edited
Loading

drafting fix for #246
testing in Lightning-AI/torchmetrics#2797

cc: @shaypal5

@Borda Borda requested a review from shaypal5 as a code owner October 23, 2024 20:40
@Borda Borda added the bug label Oct 23, 2024
@Borda Borda mentioned this pull request Oct 24, 2024
Merged
shaypal5
shaypal5 approved these changes Oct 25, 2024
View reviewed changes
Copy link
Collaborator

@shaypal5 shaypal5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. We have the unique case where our custom-defined types reside, serialized, on hard drives and databases, not updating with our code. :)

@shaypal5 shaypal5 merged commit 84fe27a into master Oct 25, 2024
33 checks passed
@shaypal5 shaypal5 deleted the fix/legacy branch October 25, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaypal5 shaypal5 shaypal5 approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Borda @shaypal5