Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: crash with None & confusing tests #248

Merged
merged 9 commits into from
Oct 25, 2024
Merged

fix: crash with None & confusing tests #248

merged 9 commits into from
Oct 25, 2024

Conversation

Borda
Copy link
Contributor

@Borda Borda commented Oct 22, 2024 •
edited
Loading

closes #247

cleaning confusing testing which hided some issues

XFAIL tests/test_pickle_core.py::test_bad_cache_file[True]
XFAIL tests/test_pickle_core.py::test_delete_cache_file[True]
XPASS tests/test_pickle_core.py::test_bad_cache_file[False]
XPASS tests/test_pickle_core.py::test_delete_cache_file[False]

cc: @shaypal5

@Borda Borda requested a review from shaypal5 as a code owner October 22, 2024 07:20
@Borda Borda added the bug label Oct 22, 2024
@Borda Borda changed the title ci/pytest: Treating warning as error tests: fix crash with None & confusing tests Oct 22, 2024
@Borda Borda changed the title tests: fix crash with None & confusing tests fix: crash with None & confusing tests Oct 22, 2024
@Borda Borda mentioned this pull request Oct 24, 2024
Merged
shaypal5
shaypal5 approved these changes Oct 25, 2024
View reviewed changes
Copy link
Collaborator

@shaypal5 shaypal5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work!

@shaypal5 shaypal5 merged commit 040e981 into master Oct 25, 2024
33 checks passed
@shaypal5 shaypal5 deleted the pytest/W branch October 25, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaypal5 shaypal5 shaypal5 approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ci: missed errors
2 participants
@Borda @shaypal5