CI: Add MSVC Debug Build #3784
CI: Add MSVC Debug Build #3784
Conversation
|
Hm, cannot reproduce the issue from microsoft/onnxruntime#9735 (comment) @skottmckay |
|
Ah, 2.9.1 definitely fixes this (likely earlier as well, did not bisect). |
| run: > | ||
| cmake -S . -B build | ||
| -G "Visual Studio 16 2019" -A Win32 | ||
| -DCMAKE_BUILD_TYPE=Debug |
There was a problem hiding this comment.
I just took a quick look at ci.yml, IIUC we don't have a Windows Debug build (only the deadsnakes valgrind build uses Debug). I'm mildly surprised, maybe I'm just overlooking something (@henryiii)? If not, adding this win32-debug block seems very useful in general, especially because Windows debug builds are fairly tricky in general (from very long-ago past experience). Good to be sure we're covered.
There was a problem hiding this comment.
Let me reopen the PR then and remove the last commit, so we have coverage?
|
I'll merge this now, to get this into the smart_holder update. |
Description
Add MSVC builds in Debug mode to CI.
cc @skottmckay
X-Ref.:
Suggested changelog entry: