Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Add MSVC Debug Build #3784

Merged
merged 1 commit into from
Mar 10, 2022
Merged

CI: Add MSVC Debug Build #3784

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 54 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -755,6 +755,60 @@ jobs:
- name: Python tests
run: cmake --build build -t pytest

win32-debug:
strategy:
fail-fast: false
matrix:
python:
- 3.8
- 3.9

include:
- python: 3.9
args: -DCMAKE_CXX_STANDARD=20
- python: 3.8
args: -DCMAKE_CXX_STANDARD=17

name: "🐍 ${{ matrix.python }} • MSVC 2019 (Debug) • x86 ${{ matrix.args }}"
runs-on: windows-2019

steps:
- uses: actions/checkout@v2

- name: Setup Python ${{ matrix.python }}
uses: actions/setup-python@v2
with:
python-version: ${{ matrix.python }}
architecture: x86

- name: Update CMake
uses: jwlawson/actions-setup-cmake@v1.12

- name: Prepare MSVC
uses: ilammy/msvc-dev-cmd@v1.10.0
with:
arch: x86

- name: Prepare env
run: |
python -m pip install -r tests/requirements.txt

# First build - C++11 mode and inplace
- name: Configure ${{ matrix.args }}
run: >
cmake -S . -B build
-G "Visual Studio 16 2019" -A Win32
-DCMAKE_BUILD_TYPE=Debug
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just took a quick look at ci.yml, IIUC we don't have a Windows Debug build (only the deadsnakes valgrind build uses Debug). I'm mildly surprised, maybe I'm just overlooking something (@henryiii)? If not, adding this win32-debug block seems very useful in general, especially because Windows debug builds are fairly tricky in general (from very long-ago past experience). Good to be sure we're covered.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me reopen the PR then and remove the last commit, so we have coverage?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

-DPYBIND11_WERROR=ON
-DDOWNLOAD_CATCH=ON
-DDOWNLOAD_EIGEN=ON
${{ matrix.args }}
- name: Build C++11
run: cmake --build build --config Debug -j 2

- name: Python tests
run: cmake --build build --config Debug -t pytest

win32-msvc2017:
name: "🐍 ${{ matrix.python }} • MSVC 2017 • x64"
runs-on: windows-2016
Expand Down