Patch MSVC pybind11 debug bug #1209
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated now upstream as pybind/pybind11#3784 |
ax3l
added
affects latest release
third party
ax3l
reviewed
Mar 7, 2022
ax3l
previously approved these changes
Mar 7, 2022
|
Hm, cannot reproduce an issue upstream. |
Merged
|
Upgrade attempt in #1220 |
|
We can patch this on the 0.14.* release line, but if #1220 passes we will take an upgrade for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our MSVC CI seems to be broken currently due to an include order error in pybind11
This PR patches our internal version of pybind11 based on this comment to fix the issue.
TODO: