Revert "Move tests (#32)" #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d18dc3d but moves the modules back under src/Test/QuickCheck/Laws/Control instead of src/Test/QuickCheck/Laws/Data to match their names.
Merged
kl0tl
commented
Dec 13, 2020
Comment on lines
19
to
+30
| "dependencies": { | ||
| "purescript-tuples": "master", | ||
| "purescript-gen": "master" | ||
| "purescript-arrays": "master", | ||
| "purescript-gen": "master", | ||
| "purescript-lists": "master", | ||
| "purescript-quickcheck": "master", | ||
| "purescript-quickcheck-laws": "master", | ||
| "purescript-tuples": "master" | ||
| }, | ||
| "devDependencies": { | ||
| "purescript-console": "master", | ||
| "purescript-effect": "master", | ||
| "purescript-psci-support": "master" |
There was a problem hiding this comment.
I noticed a few dependencies listed in the spago.dhall file are missing from the bower.json file. Do we still need this file?
There was a problem hiding this comment.
We do need to preserve this file (in order to publish the library, and for Bower users). We can generate the Bower file from the Spago file, or we can manually add the missing dependencies.
thomashoneyman
approved these changes
Dec 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit d18dc3d but moves the modules back under src/Test/QuickCheck/Laws/Control instead of src/Test/QuickCheck/Laws/Data to match their names.