Skip to content

Separate out test dependencies #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

adrianroe
Copy link

Description of the change
Changes to the spago.dhall file and move all test code to live under the test subdirectory so that projects using the library don't need the transitive test dependencies

Tests now run with
spago -x test.dhall test

@thomashoneyman
Copy link
Contributor

I'll let others weigh in as to whether we want to do this, given that Spago is getting targets (see purescript/spago#681 and purescript/spago#811), but users downloading this library via the package sets won't be using the spago.dhall file in this repository -- they use the one defined in the package sets:

https://github.com/purescript/package-sets/blob/b463e4bb76688e2b390f49b5017f01894ecb41e0/src/groups/purescript-contrib.dhall#L451-L456

The one here is just for local development. That will change when the PureScript registry comes out, though.

@adrianroe
Copy link
Author

It's not so much the spago dhall changes that motivated the PR - it was more moving the test code from the src directory to test as otherwise anything using the packages needs quickcheck available to compile, even though it's for test code.

Not all the backends to PS have access to a native Quickcheck...

@adrianroe
Copy link
Author

...and I have clearly broken your CI testing in the process (as it presumably isn't looking for a test.dhall). My apologies for that!

@thomashoneyman
Copy link
Contributor

Ah! In that case, this has been discussed before — see #32 and #33.

@adrianroe
Copy link
Author

Makes sense! Maybe one way forward would be to have purescript-these and purescript-these-verify (or -laws, -quickcheck or somesuch). I absolutely get the importance of that code for others wanting to verify their specific instances, but it's quite a heavy dependency for what I suspect is a minority use case.

No worries either way round - I concede I'm an edge case and can live with running from a fork!

Thanks for a high quality library!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants