Skip to content

Move tests #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 11, 2020
Merged

Move tests #32

merged 1 commit into from
Dec 11, 2020

Conversation

kl0tl
Copy link
Contributor

@kl0tl kl0tl commented Dec 11, 2020

Otherwise they add an unwanted dependency on quickcheck and quickcheck-laws to dependents, see the build failure of purescript-contrib/purescript-css#125.

@thomashoneyman thomashoneyman merged commit d18dc3d into purescript-contrib:main Dec 11, 2020
@kritzcreek
Copy link

I don't think this is correct. These modules are supposed to let you check that your own Align instances are law abiding, but that means you need to be able to import them. By moving them into the test directory the spago globs will no longer include them.

Maybe the solution is to move them into a these-laws? What's so bad about incurring a quickcheck dependency?

@thomashoneyman
Copy link
Contributor

Mm. I misinterpreted these, in that case (sorry @Vladciobanu!). We can instead put them back in the prior location and add the quickcheck dependency to the main set of dependencies, that's fine with me. (We'll have to update the package set once again, unfortunately @kl0tl).

kl0tl added a commit to kl0tl/purescript-these that referenced this pull request Dec 12, 2020
kl0tl added a commit to kl0tl/purescript-these that referenced this pull request Dec 12, 2020
kl0tl added a commit to kl0tl/purescript-these that referenced this pull request Dec 12, 2020
This reverts commit d18dc3d but moves the modules back under src/Test/QuickCheck/Laws/Control instead of src/Test/QuickCheck/Laws/Data to match their names.
@kl0tl
Copy link
Contributor Author

kl0tl commented Dec 12, 2020

Oh crap, I completely missed the point of these modules 🤦 It seems that they’re usually defined in quickcheck-laws instead though, is there a reason for not following the precedent here?

@thomashoneyman
Copy link
Contributor

Maybe we could check in with @Vladciobanu quickly and see what he thinks. I don’t have a firm opinion on this.

@eviefp
Copy link
Member

eviefp commented Dec 12, 2020

Well, I didn't think quickcheck-laws would want to depend on this, which is why I added them here. It would also make sense for people to just depend on this, since they have to import it in order to define the instance in the first place.

@kl0tl
Copy link
Contributor Author

kl0tl commented Dec 13, 2020

I opened #33 and purescript/package-sets#762.

thomashoneyman pushed a commit that referenced this pull request Dec 17, 2020
* Revert "Move tests (#32)"

This reverts commit d18dc3d but moves the modules back under src/Test/QuickCheck/Laws/Control instead of src/Test/QuickCheck/Laws/Data to match their names.

* Add missing bower dependencies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants