-
Notifications
You must be signed in to change notification settings - Fork 11
Move tests #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move tests #32
Conversation
I don't think this is correct. These modules are supposed to let you check that your own Maybe the solution is to move them into a |
Mm. I misinterpreted these, in that case (sorry @Vladciobanu!). We can instead put them back in the prior location and add the quickcheck dependency to the main set of dependencies, that's fine with me. (We'll have to update the package set once again, unfortunately @kl0tl). |
This reverts commit d18dc3d.
This reverts commit d18dc3d.
This reverts commit d18dc3d but moves the modules back under src/Test/QuickCheck/Laws/Control instead of src/Test/QuickCheck/Laws/Data to match their names.
Oh crap, I completely missed the point of these modules 🤦 It seems that they’re usually defined in quickcheck-laws instead though, is there a reason for not following the precedent here? |
Maybe we could check in with @Vladciobanu quickly and see what he thinks. I don’t have a firm opinion on this. |
Well, I didn't think |
I opened #33 and purescript/package-sets#762. |
Otherwise they add an unwanted dependency on quickcheck and quickcheck-laws to dependents, see the build failure of purescript-contrib/purescript-css#125.