Update PDK layout #122
Closed
Update PDK layout #122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This copies all files from puppetlabs-postgresql since I can't use PDK due to a missing puppet-module-posix-default-r3.0 gem.
ekohl
force-pushed
the
update-to-pdk-template
branch
from
e231826 to
420f31e
Compare
|
@david22swan (or not sure who else to ping) I could use some review here. This is blocking #121. |
|
Could we get a @puppetlabs/modules member to help get this module onboarded to cloud ci & autorelease please? |
|
Reminder. This is literally the last module I need to mark compatible with Puppet 7 and it's really ironic that it's in the puppetlabs namespace. If Puppet doesn't maintain this module anymore, can we move it Voxpupuli instead? |
|
Foreman has stopped using this module so I no longer have an interest in it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This copies all files from puppetlabs-postgresql since I can't use PDK due to a missing puppet-module-posix-default-r3.0 gem.