Skip to content

Drop support and compatibility for Debian < 9 and Ubuntu < 16.04 #2123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 20, 2021
Merged

Drop support and compatibility for Debian < 9 and Ubuntu < 16.04 #2123

merged 5 commits into from
Sep 20, 2021

Conversation

ekohl
Copy link
Collaborator

@ekohl ekohl commented Feb 15, 2021

This is a draft PR to push my local code. It includes #2110. The idea is to keep the codebase smaller. Maybe this is too soon, but I'd like some feedback.

Alternatives are to drop Debian < 8 and Ubuntu < 16.04.

@puppet-community-rangefinder
Copy link

apache::default_mods is a class

that may have no external impact to Forge modules.

apache is a class

Breaking changes to this file WILL impact these 149 modules (exact match):
Breaking changes to this file MAY impact these 65 modules (near match):

apache::mod::fastcgi is a class

that may have no external impact to Forge modules.

apache::mod::proxy_html is a class

Breaking changes to this file WILL impact these 1 modules (exact match):

apache::mod::ssl is a class

Breaking changes to this file WILL impact these 33 modules (exact match):
Breaking changes to this file MAY impact these 13 modules (near match):

apache::mod::suphp is a class

that may have no external impact to Forge modules.

apache::mpm is a type

that may have no external impact to Forge modules.

apache::params is a class

Breaking changes to this file WILL impact these 11 modules (exact match):
Breaking changes to this file MAY impact these 16 modules (near match):

apache::version is a class

Breaking changes to this file WILL impact these 1 modules (exact match):

This module is declared in 175 of 576 indexed public Puppetfiles.

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@sanfrancrisko
Copy link
Contributor

Let me start the conversation internally about dropping support for Debian < 9 and Ubuntu < 16.04. Now that Puppet 5 is officially EOL'd, those platforms fall under that umbrella too.

Given Debian 8 is still officially supported on Puppet 6, I'm not sure we can make any moves to deprecate any of that functionality.

@ekohl
Copy link
Collaborator Author

ekohl commented Feb 15, 2021

Let me know if I should submit the Ubuntu 10.04 removal separate. That feels like a safe one to remove at this point. I can also take a look at removing Debian < 8.

Another thing to note is that Ubuntu 16.04 standard support will go EOL in April.

@sanfrancrisko
Copy link
Contributor

Thanks @ekohl - yeah, if you could, putting up a separate PR for the removal of Ubuntu 10.04 would be good. We can get that in fairly quickly.

@ekohl
Copy link
Collaborator Author

ekohl commented Feb 22, 2021

#2129 is that. #2110 should also be merged before this PR can be moved out of draft.

@CLAassistant
Copy link

CLAassistant commented Feb 24, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ekohl
Copy link
Collaborator Author

ekohl commented Mar 15, 2021

I did split the commits a bit. I'd be interested to know what level of support is desired. The commit < 8 and < 16.04 felt safe, but it looks like 14.04 still has LTS support until 2022.

Would you mind taking a look at the commits and stating what level of support is desired?

@david22swan
Copy link
Member

@ekohl Apologies but it looks like we're set to keep Debian 8 support for a while longer as it was included in the last LTS agent release.
The Ubuntu changes on the other hand look good and I would be quite happy to merge them.

@ekohl ekohl force-pushed the fact-cleanup branch 2 times, most recently from 6458f6e to d2be2a8 Compare September 1, 2021 12:04
@ekohl
Copy link
Collaborator Author

ekohl commented Sep 1, 2021

I've rebased this and submitted #2188 to at least get the preparation out. After that's merged, I can submit the first commit as a PR. It should be safe to drop Debian < 8 and 14.04 at least.

@ekohl
Copy link
Collaborator Author

ekohl commented Sep 2, 2021

I've submitted #2189 as a first PR.

@ekohl ekohl mentioned this pull request Sep 15, 2021
Closed
@ekohl ekohl changed the title Drop support for Debian < 9 and Ubuntu < 16.04 Drop support for Debian < 9 and Ubuntu < 18.04 Sep 15, 2021
@ekohl ekohl marked this pull request as ready for review September 15, 2021 16:50
@ekohl ekohl requested a review from a team as a code owner September 15, 2021 16:50
@ekohl
Copy link
Collaborator Author

ekohl commented Sep 15, 2021

Rebased to resolve conflicts.

bastelfreak
bastelfreak previously approved these changes Sep 15, 2021
View reviewed changes
@david22swan
Copy link
Member

@ekohl Apologies but when I state yesterday that we could get this merged I was on my way out and did not recognize that this PR included the dropping of Ub16.04 which is still currently supported by the puppet agent and as such must continue to be supported by our modules.
I am attempting to find some clarification on when Ub 16.04 will be dropped and am hoping to get a response by the end of today.
Once again sorry that we can't get this PR merged as it is now.

@ekohl
Drop comments describing old Debian/Ubuntu
ae76cb5 
In 8716eb9 support for Ubuntu < 14.04
and Debian < 8 was dropped. This removes a comment describing those
versions.

Fixes: 8716eb9
@ekohl
Better nesting in spec tests
94180f4
@ekohl
Drop redundant test
fd75b58 
This is the same test case as 'with magic_file => /tmp/Debian_magic'.
@ekohl ekohl changed the title Drop support for Debian < 9 and Ubuntu < 18.04 Drop support for Debian < 9 and Ubuntu < 16.04 Sep 16, 2021
@ekohl
Copy link
Collaborator Author

ekohl commented Sep 16, 2021

I dropped the Ubuntu 16.04 removal commit and also updated the tests to default to Debian 11 instead of 8. Also cleaned up some other testing code.

bastelfreak
bastelfreak previously approved these changes Sep 16, 2021
View reviewed changes
@david22swan
Copy link
Member

@ekohl Look's like we're still getting some spec test failures

@ekohl
Copy link
Collaborator Author

ekohl commented Sep 16, 2021

Very likely. I can't run tests locally:

Could not find gem 'puppet-module-posix-default-r3.0 (~> 1.0)' in rubygems repository https://rubygems.org/ or installed locally.

I can't find the JIRA issue that @bastelfreak opened right now, but it makes contributing to PDK-based Puppet modules very painful. Which is also why puppetlabs/puppetlabs-xinetd#122 has been stuck. To verify puppetlabs/puppetlabs-xinetd#121 I actually rewrote the module to use Voxpupuli's module layout.

@bastelfreak
Copy link
Collaborator

The issue for the missing gems: https://tickets.puppetlabs.com/browse/MODULES-11161 (plus all linked issues)

@david22swan
Copy link
Member

@ekohl Took a quick look at the spec test failures and did some fixes on them, a few package names had been changed between Deb 8 and 11 and that was throwing the failures.
Currently looking at the last failure, just need to give it a proper look over but it shouldn't be too hard to fix.
Sorry for pushing up without asking but figured you'd want this done quick.

@ekohl
Copy link
Collaborator Author

ekohl commented Sep 16, 2021

I pushed another one that was still missing. I get the impression that the whole proxy_html mod was dropped in Debian 9 because I can't find the package. Or is it part of another package?

@david22swan
Copy link
Member

david22swan commented Sep 16, 2021 •
edited
Loading

@ekohl From what I can find the libapache2-mod-proxy-html package was a transitional one that was only present within 8 and removed in 9 and up. It's functionality look's to have been moved in to apache2-bin, at least from what I can find.

https://www.raspberrypi.org/forums/viewtopic.php?t=192945#p1209696

@ekohl
Switch default Debian tests from 8 to 11
fbba7bb 
Previously all test suites ran with Debian 8 facts. This switches it to
Debian 11, which is the latest supported version.
@ekohl
Drop Debian < 9 and Ubuntu < 16.04
33ae7b5
@david22swan david22swan changed the title Drop support for Debian < 9 and Ubuntu < 16.04 Drop support for Debian < 9 Sep 20, 2021
david22swan
david22swan approved these changes Sep 20, 2021
View reviewed changes
Copy link
Member

@david22swan david22swan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything LGTM so gonna go ahead and merge :)
Apologies for the wait on this

@david22swan david22swan merged commit d7a1d8c into puppetlabs:main Sep 20, 2021
@ekohl ekohl deleted the fact-cleanup branch September 20, 2021 10:23
@david22swan david22swan changed the title Drop support for Debian < 9 Drop support and compatibility for Debian < 9 Sep 20, 2021
@david22swan
Copy link
Member

Just updated the title of the pr so it's clear when displayed within the changelog

@ekohl
Copy link
Collaborator Author

ekohl commented Sep 21, 2021

This also drops Ubuntu < 16.04 (14.04 was in metadata). Shouldn't that also be in the message?

@ekohl ekohl changed the title Drop support and compatibility for Debian < 9 Drop support and compatibility for Debian < 9 and Ubuntu < 16.04 Sep 21, 2021
@david22swan
Copy link
Member

Ah, I see where I went wrong sorry. Yeh this is all good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david22swan david22swan david22swan approved these changes

@bastelfreak bastelfreak bastelfreak left review comments

Assignees
No one assigned
Labels
backwards-incompatible
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ekohl @sanfrancrisko @CLAassistant @david22swan @bastelfreak