lint fixes - remove legacy facts, remove redundant qualified class inclusion

[traylenator]

remove legacy facts, remove redundant qualified class inclusion

[puppet-community-rangefinder]

xinetd::params is a class

that may have no external impact to Forge modules.

xinetd::service is a type

Breaking changes to this file WILL impact these 16 modules (exact match):

• maxadamo-galera_maxscale
• openstack-ironic
• maxadamo-galera_proxysql
• jlondon-csync2
• themeier-rsync
• nmtcc-remctl
• theforeman-tftp
• fnerdwq-omd
• pdxcat-amanda
• puppet-amanda
• maxadamo-tiny_nas
• mosen-cups
• puppetlabs-tftp
• ccin2p3-remctl
• fraenki-galera
• puppetlabs-rsync

Breaking changes to this file MAY impact these 4 modules (near match):

• simp-tftpboot
• openstack-tripleo
• simp-vnc
• abstractit-mysql_zrm

This module is declared in 47 of 575 indexed public Puppetfiles.

---

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[traylenator]

Hi,
CERN has signed the CLA on mass.

[ekohl]

Since the Foreman installer does rely on this, I've been hoping to get this module in better shape but #122 doesn't appear to be getting any attention and I'm stuck with it. I'd prefer to first get a base layout correct so get decent CI but I really don't know what to do with it.

Right now we only rely on it on EL7 and I've opened https://community.theforeman.org/c/development/9 to talk about deprecating and eventually dropping EL7. At this rate we may drop EL7 before this module gets any attention.

[nmburgan]

So sorry, I didn't see this PR before I merged a nearly identical one of my own.