Skip to content

Update to puppet-module-gems 1.0, pdk-templates and new rubocop #1220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jan 18, 2021

Conversation

DavidS
Copy link
Contributor

@DavidS DavidS commented Dec 16, 2020

No description provided.

They're causing `Current textdomain ("master_domain") was not added, use FastGettext.add_text_domain !` error on `rake syntax` through the gettext initialisation in https://github.com/puppetlabs/puppetlabs_spec_helper/blob/172300a4c125b9089c43a39ebed9743db5416063/lib/puppetlabs_spec_helper/rake_tasks.rb#L376
@codecov-io
Copy link

Codecov Report

Merging #1220 (257f4a9) into main (08e3a51) will increase coverage by 0.37%.
The diff coverage is 54.54%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1220      +/-   ##
==========================================
+ Coverage   65.81%   66.18%   +0.37%     
==========================================
  Files          14       14              
  Lines         351      349       -2     
==========================================
  Hits          231      231              
+ Misses        120      118       -2     
Impacted Files Coverage Δ
...ns/postgresql/postgresql_acls_to_resources_hash.rb 0.00% <0.00%> (ø)
...b/puppet/functions/postgresql/postgresql_escape.rb 0.00% <0.00%> (ø)
...puppet/functions/postgresql/postgresql_password.rb 0.00% <ø> (ø)
lib/puppet/functions/postgresql_escape.rb 0.00% <ø> (ø)
lib/puppet/functions/postgresql_password.rb 0.00% <ø> (ø)
lib/puppet/provider/postgresql_conf/parsed.rb 100.00% <ø> (ø)
.../puppet/provider/postgresql_conn_validator/ruby.rb 80.00% <ø> (ø)
lib/puppet/type/postgresql_conf.rb 93.33% <ø> (ø)
lib/puppet/type/postgresql_conn_validator.rb 100.00% <ø> (ø)
lib/puppet/type/postgresql_replication_slot.rb 100.00% <ø> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d6e875...206a890. Read the comment docs.

@sheenaajay sheenaajay merged commit 0cda7bd into main Jan 18, 2021
@DavidS DavidS deleted the pdksync branch January 18, 2021 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants