Apply remaining rubocop fixes

Author: DavidS

lib/puppet/functions/postgresql/postgresql_escape.rb

@@ -25,6 +25,6 @@ def default_impl(input_string)
   end
 
   def tag_needed?(input_string)
-    input_string =~ %r{\$\$} || input_string.end_with?('$') # rubocop:disable Performance/StringInclude
+    input_string.include?('$$') || input_string.end_with?('$')
   end
 end

lib/puppet/provider/postgresql_psql/ruby.rb

@@ -31,7 +31,7 @@ def run_sql_command(sql)
 
   private
 
-  def get_environment # rubocop:disable Naming/AccessorMethodName : Refactor does not work correctly
+  def get_environment
     environment = (resource[:connect_settings] || {}).dup
     envlist = resource[:environment]
     return environment unless envlist

lib/puppet/provider/postgresql_replication_slot/ruby.rb

@@ -5,7 +5,7 @@
   commands psql: 'psql'
 
   def self.instances
-    run_sql_command('SELECT * FROM pg_replication_slots;')[0].split("\n").select { |l| l =~ %r{\|} }.map do |l| # rubocop:disable Performance/StringInclude
+    run_sql_command('SELECT * FROM pg_replication_slots;')[0].split("\n").select { |l| l.include('|') }.map do |l|
       name, *_others = l.strip.split(%r{\s+\|\s+})
       new(name: name,
           ensure: :present)

lib/puppet/util/postgresql_validator.rb

@@ -43,7 +43,7 @@ def attempt_connection(sleep_length, tries)
         Puppet.debug "PostgresqlValidator.attempt_connection: #{build_validate_cmd}"
         result = execute_command
         if result && !result.empty?
-          Puppet.debug "PostgresqlValidator.attempt_connection: Connection to #{@resource[:db_name] || parse_connect_settings.select { |elem| elem.match %r{PGDATABASE} }} successful!" # rubocop:disable Performance/StringInclude
+          Puppet.debug "PostgresqlValidator.attempt_connection: Connection to #{@resource[:db_name] || parse_connect_settings.select { |elem| elem.include?('PGDATABASE') }} successful!"
           return true
         else
           Puppet.warning "PostgresqlValidator.attempt_connection: Sleeping for #{sleep_length} seconds"