Skip to content

Move PULP SDK to main branch/fork. #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Victor-Jung merged 11 commits into from
Jun 2, 2025
Merged

Move PULP SDK to main branch/fork. #88

Victor-Jung merged 11 commits into from
Jun 2, 2025

Conversation

@FrancescoConti
Copy link
Member

@FrancescoConti FrancescoConti commented May 27, 2025 •
edited by Xeratec
Loading

This PR moves from relying on off-branch PULP SDK to the mainline one for PULP clusters.
Depends on pulp-platform/pulp-sdk#149

Added

  • N/A

Changed

  • Moved from Victor-Jung/pulp-sdk branch deeploy to pulp-platform/pulp-sdk branch main.

Fixed

  • N/A

PR Merge Checklist

  1. The PR is rebased on the latest devel commit and pointing to devel.
  2. Your PR reviewed and approved.
  3. All checks are passing.
  4. The CHANGELOG.md file has been updated.
  5. If the docker was modified, change back its link after review.

@Victor-Jung Victor-Jung added this to the Release xxx milestone May 27, 2025
@Victor-Jung Victor-Jung moved this to In review in Deeploy May 27, 2025
@FrancescoConti
Copy link
Member Author

FrancescoConti commented May 28, 2025

At this time, introduces regressions due to errors like these in linking. To check by looking at merged pulp-sdk vs the unmerged version:

ld.lld: warning: ../../../TargetLibraries/PULPOpen/CMakeFiles/pulp-sdk.dir/app/install/pulp-sdk/rtos/pulpos/common/kernel/time_asm.S.obj:(.text_l2+0xc): has non-ABS relocation R_RISCV_PCREL_HI20 against symbol 'pos_time_timer_handler'
ld.lld: error: ../../../TargetLibraries/PULPOpen/CMakeFiles/pulp-sdk.dir/app/install/pulp-sdk/rtos/pulpos/common/kernel/time_asm.S.obj:(.text_l2+0x10): has non-ABS relocation R_RISCV_PCREL_LO12_I against symbol '.Lpcrel_hi0'
ld.lld: warning: ../../../TargetLibraries/PULPOpen/CMakeFiles/pulp-sdk.dir/app/install/pulp-sdk/rtos/pulpos/common/kernel/soc_event_v2_itc.S.obj:(.text_l2+0x2c): has non-ABS relocation R_RISCV_PCREL_HI20 against symbol 'pos_soc_event_callback'
ld.lld: error: ../../../TargetLibraries/PULPOpen/CMakeFiles/pulp-sdk.dir/app/install/pulp-sdk/rtos/pulpos/common/kernel/soc_event_v2_itc.S.obj:(.text_l2+0x30): has non-ABS relocation R_RISCV_PCREL_LO12_I against symbol '.Lpcrel_hi0'
ld.lld: warning: ../../../TargetLibraries/PULPOpen/CMakeFiles/pulp-sdk.dir/app/install/pulp-sdk/rtos/pulpos/common/kernel/crt0.S.obj:(.text_l2+0x18): has non-ABS relocation R_RISCV_JAL against symbol 'pos_pe_start'
ld.lld: warning: ../../../TargetLibraries/PULPOpen/CMakeFiles/pulp-sdk.dir/app/install/pulp-sdk/rtos/pulpos/common/kernel/crt0.S.obj:(.text_l2+0x1c): has non-ABS relocation R_RISCV_PCREL_HI20 against symbol '_bss_start'
ld.lld: error: ../../../TargetLibraries/PULPOpen/CMakeFiles/pulp-sdk.dir/app/install/pulp-sdk/rtos/pulpos/common/kernel/crt0.S.obj:(.text_l2+0x20): has non-ABS relocation R_RISCV_PCREL_LO12_I against symbol '.Lpcrel_hi0'
ld.lld: warning: ../../../TargetLibraries/PULPOpen/CMakeFiles/pulp-sdk.dir/app/install/pulp-sdk/rtos/pulpos/common/kernel/task_asm.S.obj:(.text_l2+0x0): has non-ABS relocation R_RISCV_PCREL_HI20 against symbol 'pos_sched_first'
ld.lld: error: ../../../TargetLibraries/PULPOpen/CMakeFiles/pulp-sdk.dir/app/install/pulp-sdk/rtos/pulpos/common/kernel/task_asm.S.obj:(.text_l2+0x4): has non-ABS relocation R_RISCV_PCREL_LO12_I against symbol '.Lpcrel_hi0'

@FrancescoConti FrancescoConti moved this from In review to In progress in Deeploy May 28, 2025
@FrancescoConti FrancescoConti mentioned this pull request May 28, 2025
Merged
@FrancescoConti
Copy link
Member Author

FrancescoConti commented May 29, 2025

@Victor-Jung CI is now passing after reverting a recent change to the PULP SDK (Hyperbus multiple transfers), which will need further investigation:
https://github.com/FrancescoConti/Deeploy/actions/runs/15320807677

Apart from CHANGELOG.md and correct Docker linking, should I rebase this PR into a single commit?

@Victor-Jung
Copy link
Member

Victor-Jung commented May 29, 2025

No need to squash commits I do it once I merge. Will review this one Monday :)

@Victor-Jung
Copy link
Member

Victor-Jung commented Jun 2, 2025

At this time, introduces regressions due to errors like these in linking. To check by looking at merged pulp-sdk vs the unmerged version:

ld.lld: warning: ../../../TargetLibraries/PULPOpen/CMakeFiles/pulp-sdk.dir/app/install/pulp-sdk/rtos/pulpos/common/kernel/time_asm.S.obj:(.text_l2+0xc): has non-ABS relocation R_RISCV_PCREL_HI20 against symbol 'pos_time_timer_handler'
ld.lld: error: ../../../TargetLibraries/PULPOpen/CMakeFiles/pulp-sdk.dir/app/install/pulp-sdk/rtos/pulpos/common/kernel/time_asm.S.obj:(.text_l2+0x10): has non-ABS relocation R_RISCV_PCREL_LO12_I against symbol '.Lpcrel_hi0'
ld.lld: warning: ../../../TargetLibraries/PULPOpen/CMakeFiles/pulp-sdk.dir/app/install/pulp-sdk/rtos/pulpos/common/kernel/soc_event_v2_itc.S.obj:(.text_l2+0x2c): has non-ABS relocation R_RISCV_PCREL_HI20 against symbol 'pos_soc_event_callback'
ld.lld: error: ../../../TargetLibraries/PULPOpen/CMakeFiles/pulp-sdk.dir/app/install/pulp-sdk/rtos/pulpos/common/kernel/soc_event_v2_itc.S.obj:(.text_l2+0x30): has non-ABS relocation R_RISCV_PCREL_LO12_I against symbol '.Lpcrel_hi0'
ld.lld: warning: ../../../TargetLibraries/PULPOpen/CMakeFiles/pulp-sdk.dir/app/install/pulp-sdk/rtos/pulpos/common/kernel/crt0.S.obj:(.text_l2+0x18): has non-ABS relocation R_RISCV_JAL against symbol 'pos_pe_start'
ld.lld: warning: ../../../TargetLibraries/PULPOpen/CMakeFiles/pulp-sdk.dir/app/install/pulp-sdk/rtos/pulpos/common/kernel/crt0.S.obj:(.text_l2+0x1c): has non-ABS relocation R_RISCV_PCREL_HI20 against symbol '_bss_start'
ld.lld: error: ../../../TargetLibraries/PULPOpen/CMakeFiles/pulp-sdk.dir/app/install/pulp-sdk/rtos/pulpos/common/kernel/crt0.S.obj:(.text_l2+0x20): has non-ABS relocation R_RISCV_PCREL_LO12_I against symbol '.Lpcrel_hi0'
ld.lld: warning: ../../../TargetLibraries/PULPOpen/CMakeFiles/pulp-sdk.dir/app/install/pulp-sdk/rtos/pulpos/common/kernel/task_asm.S.obj:(.text_l2+0x0): has non-ABS relocation R_RISCV_PCREL_HI20 against symbol 'pos_sched_first'
ld.lld: error: ../../../TargetLibraries/PULPOpen/CMakeFiles/pulp-sdk.dir/app/install/pulp-sdk/rtos/pulpos/common/kernel/task_asm.S.obj:(.text_l2+0x4): has non-ABS relocation R_RISCV_PCREL_LO12_I against symbol '.Lpcrel_hi0'

@FrancescoConti So this error happens when compiling the PULP-SDK sources in DeeployTest, right? Just to check that there is no compilation done at install time.

@haugoug Any lucky guess on the cause of the issue?

Victor-Jung
Victor-Jung approved these changes Jun 2, 2025
View reviewed changes
Copy link
Member

@Victor-Jung Victor-Jung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I also checked that the CI passes with your Docker. Thanks for the contribution :)

@Victor-Jung Victor-Jung merged commit 7f31f19 into pulp-platform:devel Jun 2, 2025
1 of 122 checks passed
@github-project-automation github-project-automation bot moved this from In progress to Done in Deeploy Jun 2, 2025
@Xeratec Xeratec modified the milestones: Release xxx, Release 0.2.0 Jun 5, 2025
@Xeratec Xeratec mentioned this pull request Jul 8, 2025
Merged
Xeratec added a commit that referenced this pull request Jul 8, 2025
@Xeratec
Release v0.2.0 (#103)
c7fd2a1 
This release contains major architectural changes, new platform support,
enhanced simulation workflows, floating-point kernel support, training
infrastructure for CCT models, memory allocation strategies, and
documentation improvements.

After merging this into `main`, the release process will proceed with:
- Pushing a Git tag for the release after merging this PR
- Creating a GitHub release with the prepared tag.

Note: Since the release tag references the Docker container tagged with
the release tag (`ghcr.io/pulp-platform/deeploy:v0.2.0`), the CI will
initially fail. The Deeploy Docker image must be built after the release
PR is merged and the CI restarted.

### List of Pull Requests
- Prepare v0.2.0 release
[#102](#102)
- Add Luka as Code Owner
[#101](#101)
- Fix CI, Docker Files, and Documentation Workflow
[#100](#100)
- Chimera Platform Integration
[#96](#96)
- Add Tutorial and Refactor README
[#97](#97)
- Reduce Mean Float Template
[#92](#92)
- Reshape Memory Freeing and Generic Float GEMM Fixes
[#91](#91)
- Prepare for Release and Separate Dependencies
[#90](#90)
- Fix input offsets calculation
[#89](#89)
- Move PULP SDK to main branch/fork
[#88](#88)
- Finite Lifetime for IO Tensors
[#51](#51)
- Improved Memory Visualization and Multi-Layer Tiling Profiling
[#56](#56)
- Fix Linting in CI and Reformat C Files
[#86](#86)
- Fix Broken CMake Flow For pulp-sdk
[#87](#87)
- Refactor Changelog For Release
[#85](#85)
- ARM Docker Container and Minor Bug Fix
[#84](#84)
- Added Kernel for Generic Float DW Conv2D
[#63](#63)
- Autoselect Self-Hosted Runners if the Action is on Upstream
[#81](#81)
- TEST_RECENT linking on MacOS
[#78](#78)
- Add RV32IMF Picolibc support for Siracusa platform
[#66](#66)
- Improve Documentation and VSCode Support
[#76](#76)
- Debug Print Topology Pass and Code Transformation
[#75](#75)
- Find all subdirectories of Deeploy when installing with pip install
[#70](#70)
- Add milestone issue template
[#71](#71)
- Bunch of fixes and changes
[#58](#58)
- Add SoftHier platform
[#65](#65)
- rv32imf_xpulpv2 ISA support for Siracusa platform
[#64](#64)
- One LLVM To Compile Them All
[#60](#60)
- One GVSoC to Simulate Them All
[#59](#59)
- Add Support for CCT Last Layer Training with Embedding Dim 8-128
[#55](#55)
- Add CCT Classifier Training Support
[#53](#53)
- L3 Bugs: DMA Struct Datatype and Maxpool Margin Error
[#45](#45)
- DeepQuant Quantized Linear Support
[#54](#54)
- Implemented Dequant Layer for Generic and Siracusa
[#52](#52)
- Infinite Lifetime Buffers Considered in Tiling & Memory Allocation (+
Visualization) [#44](#44)
- Implemented Quant Layer for Generic and Siracusa
[#49](#49)
- Increase maximal Mchan DMA transfer sizes from 64KiB to 128KiB
[#47](#47)
- Add MiniMalloc and Decouple Memory Allocation and Tiling
[#40](#40)
- Float CCT Bugs on L3
[#37](#37)
- Memory Allocation Strategies and Visualization
[#36](#36)
- Add CODEOWNERS [#42](#42)
- Add Tiling Support to All CCT Kernels and Fix CCT Operators on
Siracusa Platform for L2
[#35](#35)
- Add Fp gemm and Softmax for Snitch platform
[#31](#31)
- Add Float Kernels for CCT
[#29](#29)
- documentation deployment
[#34](#34)
- main.c Float Cast Bugs
[#28](#28)
- Add Float GEMM on PULP with Tiling
[#26](#26)
- Add Float Support & Float GEMM for Generic
[#25](#25)
- GVSOC support for the Snitch Cluster platform
[#23](#23)
- Snitch Cluster Tiling Support
[#22](#22)
- Snitch support integration
[#14](#14)
- Update bibtex citation
[#20](#20)
- the PR template location, bump min python to 3.10, change install
command [#17](#17)
- Add pre-commit for python formatting
[#15](#15)
- FP integration (v2)
[#12](#12)
- shell for sequential tests of Generic, Cortex, and Mempool platforms
[#11](#11)
- Add issue templates
[#10](#10)
- Minor CI and Readme Improvements
[#8](#8)
- Fix GHCR Link for Docker Build
[#7](#7)
- neureka's ccache id
[#6](#6)
- GitHub-based CI/CD Flow
[#4](#4)
- Generic Softmax Kernel
[#2](#2)
- Port GitLab CI [#1](#1)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Victor-Jung Victor-Jung Victor-Jung approved these changes

@Xeratec Xeratec Awaiting requested review from Xeratec Xeratec is a code owner

Assignees

@FrancescoConti FrancescoConti

Labels

None yet

Projects

Deeploy
Status: Done

Milestone

Release 0.2.0

Development

Successfully merging this pull request may close these issues.

3 participants

@FrancescoConti @Victor-Jung @Xeratec