Added Kernel for Generic Float DW Conv2D #63

diaconuccalin · 2025-05-05T15:56:43Z

Created the kernel for generic float DW Conv2D and intorduced bias handling for regular and DW Conv2D.

Added

Generic float DW Conv2D kernel and bindings.
Bias handling and computation for regular and DW Conv2D.
Empty bias handling for generic regular and DW Conv2D.
Tests for Conv2D regular and DW, with and without bias (and included them in the CI pipeline).
Make target for reformatting only the files that are changed by current branch

Changed

Fixed

PR Merge Checklist

The PR is rebased on the latest devel commit and pointing to devel.
Your PR reviewed and approved.
All checks are passing.
The CHANGELOG.md file has been updated.
If the docker was modified, change back its link after review.

…ling (but no computation in the kernel) for biases in regular and DW Conv2D parsers

Signed-off-by: Diaconu Călin <diaconuccalin@gmail.com>

…Conv2D DW generic kernel to support #out_channels == k * #in_channels, where k is a positive integer, like in the Torch implementation.

Victor-Jung

Ciao Calin, thanks for your contribution! One comment on the zero bias optimization, let's make this a pass instead of a parser optimization (more code reuse and more explicit).

Also, there are many changes that are just code formatting, please revert these changes we don't need them.

Deeploy/Targets/Generic/Parsers.py

DeeployTest/Platforms/Generic/main.c

DeeployTest/Platforms/Siracusa/src/deeploytest.c

TargetLibraries/Generic/inc/kernel/Gemm.h

TargetLibraries/Generic/inc/kernel/Div.h

TargetLibraries/Generic/inc/kernel/Layernorm.h

This reverts commit edc43e1.

* New ISA support for Siracusa platform --------- Co-authored-by: Run Wang <52746141+SamanthaWangdl@users.noreply.github.com>

…Conv2D DW generic kernel to support #out_channels == k * #in_channels, where k is a positive integer, like in the Torch implementation.

This reverts commit edc43e1.

…eploy into float_conv2d_dw

Signed-off-by: Călin Diaconu <diaconuccalin@gmail.com>

…urrent branch

Signed-off-by: Călin Diaconu <diaconuccalin@gmail.com>

Victor-Jung

LGTM, the pass you implemented looks good! One minor question on the format diff script and we should be good to go for this one :)

scripts/format_diff_only.sh

…ied in current branch" This reverts commit f24288e.

This release contains major architectural changes, new platform support, enhanced simulation workflows, floating-point kernel support, training infrastructure for CCT models, memory allocation strategies, and documentation improvements. After merging this into `main`, the release process will proceed with: - Pushing a Git tag for the release after merging this PR - Creating a GitHub release with the prepared tag. Note: Since the release tag references the Docker container tagged with the release tag (`ghcr.io/pulp-platform/deeploy:v0.2.0`), the CI will initially fail. The Deeploy Docker image must be built after the release PR is merged and the CI restarted. ### List of Pull Requests - Prepare v0.2.0 release [#102](#102) - Add Luka as Code Owner [#101](#101) - Fix CI, Docker Files, and Documentation Workflow [#100](#100) - Chimera Platform Integration [#96](#96) - Add Tutorial and Refactor README [#97](#97) - Reduce Mean Float Template [#92](#92) - Reshape Memory Freeing and Generic Float GEMM Fixes [#91](#91) - Prepare for Release and Separate Dependencies [#90](#90) - Fix input offsets calculation [#89](#89) - Move PULP SDK to main branch/fork [#88](#88) - Finite Lifetime for IO Tensors [#51](#51) - Improved Memory Visualization and Multi-Layer Tiling Profiling [#56](#56) - Fix Linting in CI and Reformat C Files [#86](#86) - Fix Broken CMake Flow For pulp-sdk [#87](#87) - Refactor Changelog For Release [#85](#85) - ARM Docker Container and Minor Bug Fix [#84](#84) - Added Kernel for Generic Float DW Conv2D [#63](#63) - Autoselect Self-Hosted Runners if the Action is on Upstream [#81](#81) - TEST_RECENT linking on MacOS [#78](#78) - Add RV32IMF Picolibc support for Siracusa platform [#66](#66) - Improve Documentation and VSCode Support [#76](#76) - Debug Print Topology Pass and Code Transformation [#75](#75) - Find all subdirectories of Deeploy when installing with pip install [#70](#70) - Add milestone issue template [#71](#71) - Bunch of fixes and changes [#58](#58) - Add SoftHier platform [#65](#65) - rv32imf_xpulpv2 ISA support for Siracusa platform [#64](#64) - One LLVM To Compile Them All [#60](#60) - One GVSoC to Simulate Them All [#59](#59) - Add Support for CCT Last Layer Training with Embedding Dim 8-128 [#55](#55) - Add CCT Classifier Training Support [#53](#53) - L3 Bugs: DMA Struct Datatype and Maxpool Margin Error [#45](#45) - DeepQuant Quantized Linear Support [#54](#54) - Implemented Dequant Layer for Generic and Siracusa [#52](#52) - Infinite Lifetime Buffers Considered in Tiling & Memory Allocation (+ Visualization) [#44](#44) - Implemented Quant Layer for Generic and Siracusa [#49](#49) - Increase maximal Mchan DMA transfer sizes from 64KiB to 128KiB [#47](#47) - Add MiniMalloc and Decouple Memory Allocation and Tiling [#40](#40) - Float CCT Bugs on L3 [#37](#37) - Memory Allocation Strategies and Visualization [#36](#36) - Add CODEOWNERS [#42](#42) - Add Tiling Support to All CCT Kernels and Fix CCT Operators on Siracusa Platform for L2 [#35](#35) - Add Fp gemm and Softmax for Snitch platform [#31](#31) - Add Float Kernels for CCT [#29](#29) - documentation deployment [#34](#34) - main.c Float Cast Bugs [#28](#28) - Add Float GEMM on PULP with Tiling [#26](#26) - Add Float Support & Float GEMM for Generic [#25](#25) - GVSOC support for the Snitch Cluster platform [#23](#23) - Snitch Cluster Tiling Support [#22](#22) - Snitch support integration [#14](#14) - Update bibtex citation [#20](#20) - the PR template location, bump min python to 3.10, change install command [#17](#17) - Add pre-commit for python formatting [#15](#15) - FP integration (v2) [#12](#12) - shell for sequential tests of Generic, Cortex, and Mempool platforms [#11](#11) - Add issue templates [#10](#10) - Minor CI and Readme Improvements [#8](#8) - Fix GHCR Link for Docker Build [#7](#7) - neureka's ccache id [#6](#6) - GitHub-based CI/CD Flow [#4](#4) - Generic Softmax Kernel [#2](#2) - Port GitLab CI [#1](#1)

diaconuccalin added 2 commits May 5, 2025 17:47

Added binding and kernel for generic float DW Conv2D. Added bias hand…

5d65505

…ling (but no computation in the kernel) for biases in regular and DW Conv2D parsers

Updated changelog

fe90854

diaconuccalin requested review from Victor-Jung and Xeratec as code owners May 5, 2025 15:56

diaconuccalin changed the title ~~Generic Float DW Conv2d~~ Added Kernel for Generic Float DW Conv2D May 5, 2025

Victor-Jung assigned diaconuccalin May 6, 2025

diaconuccalin added 2 commits May 6, 2025 09:34

Applied formatting

135cf70

Merge branch 'devel' into float_conv2d_dw

f7e471d

Signed-off-by: Diaconu Călin <diaconuccalin@gmail.com>

diaconuccalin marked this pull request as draft May 12, 2025 08:31

diaconuccalin changed the title ~~Added Kernel for Generic Float DW Conv2D~~ [Draft] Added Kernel for Generic Float DW Conv2D May 12, 2025

diaconuccalin added 7 commits May 12, 2025 17:04

Added bias handling for DW Conv2D Generic kernel

8deb735

Added bias handling for float regular Conv2D Generic kernel

123c26f

Added regular and DW float Conv2D tests with biases. Fixed the float …

faa0965

…Conv2D DW generic kernel to support #out_channels == k * #in_channels, where k is a positive integer, like in the Torch implementation.

Restored deleted file

48fe8cc

Added new regular and DW float Conv2D bias tests to generic CI pipeline

6e3460e

Reformat

edc43e1

Updated CHANGELOG

2356bc9

diaconuccalin changed the title ~~[Draft] Added Kernel for Generic Float DW Conv2D~~ Added Kernel for Generic Float DW Conv2D May 13, 2025

diaconuccalin marked this pull request as ready for review May 13, 2025 13:46

Fixed naming in CI file

32624d0

Victor-Jung requested changes May 14, 2025

View reviewed changes

diaconuccalin and others added 9 commits May 15, 2025 10:00

Revert "Reformat"

762030b

This reverts commit edc43e1.

rv32imf_xpulpv2 ISA support for Siracusa platform (pulp-platform#64)

b705fa7

* New ISA support for Siracusa platform --------- Co-authored-by: Run Wang <52746141+SamanthaWangdl@users.noreply.github.com>

Added bias handling for DW Conv2D Generic kernel

79af6a2

Added bias handling for float regular Conv2D Generic kernel

d33f374

Added regular and DW float Conv2D tests with biases. Fixed the float …

d42534f

…Conv2D DW generic kernel to support #out_channels == k * #in_channels, where k is a positive integer, like in the Torch implementation.

Restored deleted file

fb92ab2

Added new regular and DW float Conv2D bias tests to generic CI pipeline

eb623ea

Reformat

1668d8e

Updated CHANGELOG

8f6d509

diaconuccalin added 7 commits May 15, 2025 16:03

Fixed naming in CI file

c95c5a6

Revert "Reformat"

98cd5ab

This reverts commit edc43e1.

Merge branch 'float_conv2d_dw' of https://github.com/diaconuccalin/De…

87fb976

…eploy into float_conv2d_dw

Merge branch 'devel' into float_conv2d_dw

b7162a7

Signed-off-by: Călin Diaconu <diaconuccalin@gmail.com>

Created new make target and script to only format files modified in c…

f24288e

…urrent branch

Applied formatting

c63c774

Moved the empty conv bias optimization from parser to optimization

4210ce2

diaconuccalin requested a review from Victor-Jung May 15, 2025 18:16

Victor-Jung added the Feature Addition of new features label May 18, 2025

diaconuccalin added 2 commits May 20, 2025 12:41

Merge branch 'devel' into float_conv2d_dw

1304409

Signed-off-by: Călin Diaconu <diaconuccalin@gmail.com>

Merge branch 'devel' into float_conv2d_dw

ae750da

Signed-off-by: Călin Diaconu <diaconuccalin@gmail.com>

Victor-Jung reviewed May 22, 2025

View reviewed changes

scripts/format_diff_only.sh Outdated Show resolved Hide resolved

Revert "Created new make target and script to only format files modif…

980c230

…ied in current branch" This reverts commit f24288e.

Xeratec added this to Deeploy May 22, 2025

Xeratec added this to the Release xxx milestone May 22, 2025

Victor-Jung moved this to In review in Deeploy May 22, 2025

Victor-Jung approved these changes May 22, 2025

View reviewed changes

diaconuccalin merged commit b341a66 into pulp-platform:devel May 22, 2025
122 checks passed

github-project-automation bot moved this from In review to Done in Deeploy May 22, 2025

Xeratec modified the milestones: Release xxx, Release 0.2.0 May 22, 2025

Xeratec mentioned this pull request Jul 8, 2025

Release v0.2.0 #103

Merged

diaconuccalin deleted the float_conv2d_dw branch November 19, 2025 10:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added Kernel for Generic Float DW Conv2D #63

Added Kernel for Generic Float DW Conv2D #63

Uh oh!

diaconuccalin commented May 5, 2025 •

edited by Xeratec

Loading

Uh oh!

Victor-Jung left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Victor-Jung left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Added Kernel for Generic Float DW Conv2D #63

Added Kernel for Generic Float DW Conv2D #63

Uh oh!

Conversation

diaconuccalin commented May 5, 2025 • edited by Xeratec Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Added

Changed

Fixed

PR Merge Checklist

Uh oh!

Victor-Jung left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Victor-Jung left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

diaconuccalin commented May 5, 2025 •

edited by Xeratec

Loading