Skip to content

Conversation

@ps2
Copy link
Owner

@ps2 ps2 commented Dec 31, 2019

  • PumpManagers are now plugins
  • Dose reconciliation fixes
  • Confirmation beeps on omnipod integration
  • Xcode 11, Dark Mode
  • Remove overrides support in NS integration
  • Revert x15 bolus patch
  • New Translations: Japanese, Danish, Swedish, Vietnamese, Finnish, Portuguese, Polish, and Romanian

ps2 and others added 30 commits January 31, 2019 15:49
* MinimedPumpManager changes for PumpManager protocol updates

* devicesSectionIndex is not changed after initialization

* Bump LoopKit rev

* Fix handling settings completion

* Don't push root viewcontroller

* Wrap unsuspend for bolus errors in SetBolusError.certain

* Allow PumpState mock creation

* Create suspend resume cell via cell reuse

* Remove unused argument

* Use higher res delivery for x23 pumps for roundToDeliveryIncrement

* Guard access to MinimedPumpManagerState

* Code organization

* dequeue SuspendResumeTableViewCell

* Remove unneeded conditional let

* Fix typo

* Make some properties immutable on MinimedPumpManagerState

* Add notes about thread issues

* Include dose in enactBolus completion

* Dismiss settings controller on minimed pumpmanager delete

* Bump LoopKit rev

* Setup controller is presented modally

* x23 pumps speed up bolus delivery to fit in 5 minute window

* present instead of show settings vc

* Remove zero bolus error; use assertionFailure instead

* Fix vc present() call

* ReservoirVolumeHUDView interface changed

* Use active flag instead of appear/disapper methods

* Bump loopkit rev

* HUDProvider active -> visible

* Add Comparable.clamped(to:) method

* Updates from @mpangburn's review

* Remove another unnecessary optional let

* Bump LoopKit rev

* use dev LoopKit
* Define allowed rates for x23 and x22 pumps, and integrate new basal picker

* Point cartfile at tidepool branch

* Use tidepool-org/LoopKit basal-picker branch
- Fixes a deadlock case in RileyLinkDevice
- Marks frameworks as using only extension-safe API
- Fixes Swift warnings
- Reduces the number of tune retries when tuning automatically
* Add new pump precision methods required by PumpManager protocol

* Fix boundary bug, and update to LoopKit changes
* Bolus progress and cancelling support

* Point to LoopKit with bolus progress changes

* Support multiple observers of dose progress

* Notify outside of lock

* subclass DoseProgressTimerEstimator

* Protocol naming update

* PumpManager createBolusProgressReporter implementation for minimed

* Updates from reviews

* Use LoopKit dev

* Add LoopKit dependency for RileyLinkBLEKit

* Update tests with new initializer signature for BolusCarelinkMessageBody
Sync diy rl dev to tidepool rl dev
* Use xcode 10.2 for travis

* MinimedPumpManager thread-safety audit

* LoopKit updates

* Update LoopKit rev and implement DeviceManagerDelegate methods
* Update Localizable.strings

Updated translations for wrong and missing texts

* Update Localizable.strings

Corrected wrong German texts, which seemed erroneously Spanish; harmonized German texts

* Update Localizable.strings

Finetuning translations to German
ps2 and others added 29 commits September 9, 2019 12:18
* Updates for Xcode 11

* Use systemBackground color for RileyLink image

* Dark Mode fixes

* More dark mode updates

* Use xcode11 branches

* Bump carthage revs
#554)

* Adjust activatedAt (and thus expiresAt) on Pod responses to account for clock drift
Round alert configuration times to the nearest minute

* Fixed and improved logic & comments for when to rewrite activatedAt
…dAt fixed again (#555)

* Adjust activatedAt (and thus expiresAt) on Pod responses to account for clock drift
Round alert configuration times to the nearest minute

* Fixed and improved logic & comments for when to rewrite activatedAt

* Make activatedAt fixed again and expiresAt persistent & changeable

* Set expiresAt appropriately when initializing from persistent storage
* Upload device id and bundle identifier

* Bulk deletion of treatments using client ids

* Fix basal rate bug

* Bump carthage revs

* Use separate representation for indefinite duration treatments

* Call completion handler on no items to delete

* Fix typo
* Revert x15 patch

* Travis build with iPhone 8 target
* Various internal improvements for better Omnipod support
+ Change Play Test Beeps to not emit a second beep type (it plays well after the UI has reported Succeeded)
+ Change the PodAlert enum description string to add “ (inactive)” for inactive configured alerts
+ Add a new Pod.cannulaInsertionUnits constant of 0.5
+ Add a new Pod.nominalPodLife constant (i.e., 72 hours)
+ Updated comments for the BeepType & BeepConfigType enums
+ Update the MessageLog description string to include a blank line before and after
+ Rename the OmnipodPumpManager hasSetupCompletePod var to hasSetupPod
+ Move readFlashLog() from PodCommsSession to OmnipodPumpManager
+ Call the setTime(), setBasalSchedule(), resumeBasal(), setTempBasal() functions with all parameters from OmnipodPumpManager
+ Mark the PodCommsSession’s configureAlerts() and cancelNone() functions with @discardableResult
+ Change beepConfig() to catch errors and never throw
+ Don't do the unneeded configuration for the autoOffAlarm alert
+ Updated PodCommsSession functions to be able to set individual optional alerts values
+ Only save the first fault status returned in podState
+ Updated and improved comments and Xcode logging

* Remove 5 currently never called  utility routines to simplify the PR
* Detect remote flag for commands

* Fix tests

* Handle remote trigger flag for BolusNormal on x22 pumps
…#567)

* Calculate insertion wait time from Pod cannulaInsertionUnits constant

* New primeDeliveryRate, secondsPerPrimePulse & secondsPerBolusPulse constants
… amounts reported from Pod (#563)

* Exclude the cannula insertion bolus amount from the calculated insulin delivered

* Add a new persistent setupUnitsDelivered PodState variable to save setup amount counted
by Pod as being actually delivered so that the user reported Insulin Delivered starts at 0 U.
* Update MinimedPumpIDSetupViewController.swift

* Update PumpRegion.swift

* Update PumpOpsSession.swift

Add .canada PumpRegion

* Update PumpOpsSession.swift
* Record pod responses before trying to parse to ensure they get logged
Part of fix for #569

* Improved logic to avoid logging partial messages and to mark failed responses

* Don't do any logging for a garbage message
* Attempt resolution of uncertain bolus while canceling

* Add packet logging for sysdiagnose
* Allow a nonce command to appear anywhere in a message
* Pass on optional programReminderInterval argument to the underlying insulin Extra functions
* Deleting unused infoplist.strings

* Adding OmniKit and OmniKitUI localizable.strings and touchups on existing genstrings

* Adding new translations for old languages

* Initial add of Japanese, Vietnamese, Swedish, Portuguese (BRA), Danish, and Finnish

* Adding available new language translations (mostly Vietnamese, Swedish, Finnish, and Portuguese)

* Localizing OmniPodKitUI's OmnipodPumpManager.storyboard

* omnipodPumpManager storyboard translation additions for French, Finnish, Portuguese, Dutch

* typo fix

* Touchups for spanish

* adding Romanian

* All languages

* typo fixes

* typo fixes

* last of typo fixes

* completing portuguese, japanese, and danish

* swedish touchups

* romanian and finnish
* Upgrade Bolus Beeps to more general purpose Confirmation Beeps
which are Loop's version of the PDM's Confidence Reminders functionality
that when enabled adds confirmation beeps for user initiated Pod activity when doing
Suspend/Resume Delivery, Change Time Zone, Change Basal Rate, Test Command & upon completion of Pod Setup.

* emitConfirmationBeep() simplifcation

* beep when returning to normal basal if doing temp basal confirmation beeps

* Remove the ability to easily customize the level of confirmation beeps
#576)

* Provide an explicit Read Pod Status command for OmniKit's Pod Settings
Analogous functionality for MinimedKit's Read Pump Status command

* Rework to allow for localization of Read Pod Status labels
Improved error checking and log messages
@ps2 ps2 merged commit 5c43423 into master Dec 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants