Add new pump precision methods required by PumpManager protocol #501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darinkrauss
suggested changes
Mar 8, 2019
Contributor
darinkrauss
left a comment
darinkrauss
left a comment
There was a problem hiding this comment.
Only one thing that really needs a look at, plus a nit for your consideration.
| return state.pumpModel.supportedBasalRates | ||
| } | ||
|
|
||
| public var supportedBolusVolumes: [Double] { |
Contributor
There was a problem hiding this comment.
[nit] Order here the same as in the protocol?
MinimedKit/Models/PumpModel.swift
Outdated
| } | ||
|
|
||
| public var supportedBolusVolumes: [Double] { | ||
| return supportedBasalRates.filter { $0 < maximumBolusVolume } |
Contributor
There was a problem hiding this comment.
I think < should be <=.
| } | ||
|
|
||
| public var maximumBasalRate: Double { | ||
| return 35 |
Contributor
There was a problem hiding this comment.
Really!?! Wow. (Nothing wrong, just shocked this is so high.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.