Basal picker #499
Basal picker #499
Conversation
| @@ -1 +1 @@ | |||
| github "LoopKit/LoopKit" "dev" | |||
| github "tidepool-org/LoopKit" "basal-picker" | |||
There was a problem hiding this comment.
What's your typical Cartfile strategy for merging changes that depend on different branches? Switch to the dependent branch while testing, then revert the Cartfile after merging?
There was a problem hiding this comment.
Yes. For me, I can build in a workspace setup, and not worry to much about updating carthage specs, but travis needs it updated, and if others check out the branch, it helps them be able to build.
darinkrauss
left a comment
darinkrauss
left a comment
There was a problem hiding this comment.
I think the range for rateGroup1 is incorrect and the Cartfile and Cartfile.resolved need to be fixed to point back to LoopKit/LoopKit, but otherwise looks good.
| public var supportedBasalRates: [Double] { | ||
| if generation >= 23 { | ||
| // 0.025 units (for rates between 0.0-0.975 U/h) | ||
| let rateGroup1 = ((0...38).map { Double($0) / Double(pulsesPerUnit) }) |
| } | ||
|
|
||
| public var maximumBasalScheduleEntryCount: Int { | ||
| return 48 |
There was a problem hiding this comment.
Really? Wow! I didn't know it supported 48.
There was a problem hiding this comment.
Yeah, It was a little bit of a pain to test, but the pump accepted it!
No description provided.