-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invalid face attribute :background nil #15
Comments
Hello @Jousimies and thanks for taking the time to report this. I cannot reproduce this on my end. These are the steps I followed:
(require 'modus-themes "~/.emacs.d/site-lisp/packages/modus-themes/modus-themes.el") ; check the path
(setq modus-themes-italic-constructs t)
(setq modus-themes-bold-constructs nil)
(setq modus-themes-region '(bg-only no-extend))
(setq modus-themes-lang-checkers '(background text-also straight-underline))
(setq modus-themes-links '(faint))
(setq modus-themes-mode-line '(accented borderless))
(modus-themes-load-themes)
(load-theme 'modus-operandi t)
Can you try those steps and let me know if you get the same results as I do? If you do, then there must be something wrong with another package that you use and how it expects some background value that does not exist. Maybe there still is something in the themes, but we need to determine what produces the error. |
I think I found the problem on the side of the themes. I pushed the changes. Though there still may be another package involved. |
@protesilaos Thank you for your help. I found the problem related to the centaur-tabs package. |
Very well! If you can pinpoint it, then we should report it to the centaur-tabs maintainer so that other users do not experience similar problems. Also, I would be curious to know what it is, just so I can learn what to expect next time something similar happens. |
@Jousimies do you have the solution for this; I'm seeing it in my build as well. |
@jeremyf I am trying to fix the problem upstream: ema2159/centaur-tabs#179. Basically, the way centaur-tabs' faces are designed right now prevent us from using Relevant issue in the GitLab mirror: https://gitlab.com/protesilaos/modus-themes/-/issues/288 |
centaur-tabs has a bug where it cannot read the value of a face if it uses the standard ':inherit' attribute. I have sent a patch to fix it, but have received no response since February: <ema2159/centaur-tabs#179>. Relevant reports: - <#30> - <https://gitlab.com/protesilaos/modus-themes/-/issues/288> - <#15> I am happy to reinstate support for centaur-tabs as soon as the package gets the maintenance it needs.
I had removed support for centaur-tabs in commit 2235ce5 (done on 2022-08-02). I wrote: centaur-tabs has a bug where it cannot read the value of a face if it uses the standard ':inherit' attribute. I have sent a patch to fix it, but have received no response since February: <ema2159/centaur-tabs#179>. Relevant reports: - <#30> - <https://gitlab.com/protesilaos/modus-themes/-/issues/288> - <#15> I am happy to reinstate support for centaur-tabs as soon as the package gets the maintenance it needs. My patch/pull-request is now merged and the package is actively maintained once again. Hence the decision to bring back support for it, as promised.
The
Invalid face attribute :background nil
error increase with mouse scrollMy config:
The text was updated successfully, but these errors were encountered: