Skip to content

Commit

Permalink
Reinstate support for centaur-tabs
Browse files Browse the repository at this point in the history
I had removed support for centaur-tabs in commit 2235ce5 (done on
2022-08-02).  I wrote:

    centaur-tabs has a bug where it cannot read the value of a face if it
    uses the standard ':inherit' attribute.  I have sent a patch to fix it,
    but have received no response since February:
    <ema2159/centaur-tabs#179>.

    Relevant reports:

    - <#30>
    - <https://gitlab.com/protesilaos/modus-themes/-/issues/288>
    - <#15>

    I am happy to reinstate support for centaur-tabs as soon as the package
    gets the maintenance it needs.

My patch/pull-request is now merged and the package is actively
maintained once again.  Hence the decision to bring back support for it,
as promised.
  • Loading branch information
protesilaos committed Sep 20, 2022
1 parent e4ee971 commit 10a0c9f
Show file tree
Hide file tree
Showing 3 changed files with 59 additions and 44 deletions.
90 changes: 46 additions & 44 deletions doc/modus-themes.info
Original file line number Diff line number Diff line change
Expand Up @@ -4540,6 +4540,8 @@ have lots of extensions, so the “full support” may not be 100% true…
• calendar and diary
• calfw
• calibredb
• centaur-tabs [ Part of 2.7.0-dev. It was removed for a while as
the package was not maintained. We are bringing back support. ]
• cfrs
• change-log and log-view (such as ‘vc-print-log’,
‘vc-print-root-log’)
Expand Down Expand Up @@ -6995,50 +6997,50 @@ Node: Custom hl-todo colors187385
Node: Add support for solaire-mode188906
Node: Face coverage191824
Node: Supported packages192276
Node: Indirectly covered packages198951
Node: Notes on individual packages200079
Node: Note on calendarel weekday and weekend colors201223
Node: Note on git-gutter in Doom Emacs202371
Node: Note on php-mode multiline comments204459
Node: Note on underlines in compilation buffers205212
Node: Note on inline Latex in Org buffers206049
Node: Note on dimmerel206659
Node: Note on display-fill-column-indicator-mode208144
Node: Note on highlight-parenthesesel209542
Node: Note on mmm-modeel background colors215592
Node: Note for prism217907
Node: Note for god-mode221063
Node: Note on company-mode overlay pop-up222667
Ref: Note on company-mode overlay pop-up-Footnote-1223357
Ref: Note on company-mode overlay pop-up-Footnote-2223424
Node: Note on ERC escaped color sequences223479
Ref: Note on ERC escaped color sequences-Footnote-1224907
Node: Note on powerline or spaceline225017
Node: Note on SHR colors225431
Node: Note on SHR fonts225855
Node: Note on Ement colors and fonts226488
Node: Note on Helm grep227987
Node: Note on pdf-tools link hints229457
Node: Note on the Notmuch logo231904
Node: Note on goto-address-mode faces232442
Node: Frequently Asked Questions233544
Node: Is the contrast ratio about adjacent colors?234175
Node: What does it mean to avoid exaggerations?235682
Node: Why are colors mostly variants of blue magenta cyan?237511
Node: What is the best setup for legibility?241817
Node: Are these color schemes?244462
Node: Port the Modus themes to other platforms?248182
Node: Contributing250963
Node: Sources of the themes251360
Node: Issues you can help with252059
Node: Patches require copyright assignment to the FSF253631
Node: Acknowledgements255851
Node: Other notes about the project259377
Node: GNU Free Documentation License262375
Node: Indices287752
Node: Function index287931
Node: Variable index289734
Node: Concept index292021
Node: Indirectly covered packages199094
Node: Notes on individual packages200222
Node: Note on calendarel weekday and weekend colors201366
Node: Note on git-gutter in Doom Emacs202514
Node: Note on php-mode multiline comments204602
Node: Note on underlines in compilation buffers205355
Node: Note on inline Latex in Org buffers206192
Node: Note on dimmerel206802
Node: Note on display-fill-column-indicator-mode208287
Node: Note on highlight-parenthesesel209685
Node: Note on mmm-modeel background colors215735
Node: Note for prism218050
Node: Note for god-mode221206
Node: Note on company-mode overlay pop-up222810
Ref: Note on company-mode overlay pop-up-Footnote-1223500
Ref: Note on company-mode overlay pop-up-Footnote-2223567
Node: Note on ERC escaped color sequences223622
Ref: Note on ERC escaped color sequences-Footnote-1225050
Node: Note on powerline or spaceline225160
Node: Note on SHR colors225574
Node: Note on SHR fonts225998
Node: Note on Ement colors and fonts226631
Node: Note on Helm grep228130
Node: Note on pdf-tools link hints229600
Node: Note on the Notmuch logo232047
Node: Note on goto-address-mode faces232585
Node: Frequently Asked Questions233687
Node: Is the contrast ratio about adjacent colors?234318
Node: What does it mean to avoid exaggerations?235825
Node: Why are colors mostly variants of blue magenta cyan?237654
Node: What is the best setup for legibility?241960
Node: Are these color schemes?244605
Node: Port the Modus themes to other platforms?248325
Node: Contributing251106
Node: Sources of the themes251503
Node: Issues you can help with252202
Node: Patches require copyright assignment to the FSF253774
Node: Acknowledgements255994
Node: Other notes about the project259520
Node: GNU Free Documentation License262518
Node: Indices287895
Node: Function index288074
Node: Variable index289877
Node: Concept index292164

End Tag Table

Expand Down
1 change: 1 addition & 0 deletions doc/modus-themes.org
Original file line number Diff line number Diff line change
Expand Up @@ -4514,6 +4514,7 @@ have lots of extensions, so the "full support" may not be 100% true…
+ calendar and diary
+ calfw
+ calibredb
+ centaur-tabs [ Part of {{{development-version}}}. It was removed for a while as the package was not maintained. We are bringing back support. ]
+ cfrs
+ change-log and log-view (such as ~vc-print-log~, ~vc-print-root-log~)
+ chart
Expand Down
12 changes: 12 additions & 0 deletions modus-themes.el
Original file line number Diff line number Diff line change
Expand Up @@ -4659,6 +4659,18 @@ by virtue of calling either of `modus-themes-load-operandi' and
`(calibredb-mark-face ((,class :inherit modus-themes-mark-sel)))
`(calibredb-size-face (( )))
`(calibredb-tag-face ((,class :foreground ,magenta-alt-faint)))
;;;;; centaur-tabs
`(centaur-tabs-active-bar-face ((,class :background ,blue-active)))
`(centaur-tabs-close-mouse-face ((,class :inherit bold :foreground ,red-active :underline t)))
`(centaur-tabs-close-selected ((,class :inherit centaur-tabs-selected)))
`(centaur-tabs-close-unselected ((,class :inherit centaur-tabs-unselected)))
`(centaur-tabs-modified-marker-selected ((,class :inherit centaur-tabs-selected)))
`(centaur-tabs-modified-marker-unselected ((,class :inherit centaur-tabs-unselected)))
`(centaur-tabs-default ((,class :background ,bg-main)))
`(centaur-tabs-selected ((,class :inherit modus-themes-tab-active)))
`(centaur-tabs-selected-modified ((,class :inherit (italic centaur-tabs-selected))))
`(centaur-tabs-unselected ((,class :inherit modus-themes-tab-inactive)))
`(centaur-tabs-unselected-modified ((,class :inherit (italic centaur-tabs-unselected))))
;;;;; cfrs
`(cfrs-border-color ((,class :background ,fg-window-divider-inner)))
;;;;; change-log and log-view (`vc-print-log' and `vc-print-root-log')
Expand Down

0 comments on commit 10a0c9f

Please sign in to comment.