Ensure that face-background reads indirect values #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old design would return an inappropriate nil value if the referenced face did not have an explicit background attribute. This can happen if a theme uses ':inherit' instead of specifying the face attributes directly. By declaring a fallback value, we make sure that such indirection will note return a nil value. This is related to issue 178: <ema2159#178>.
This was referenced May 14, 2022
|
Hi @ema2159, Can you please have a look and push this PR! Thanks |
Closed
|
Hi @nebhrajani-a, @ema2159 , Tested this PR and it fixed #187 . Setting both options to Just setting one option fixed it. Went with |
That would mean there are more cases where a fallback value needs to be specified. I can do it, if you want, but let's wait for this to be finalised first. |
|
@ema2159 friendly ping. |
protesilaos
added a commit
to protesilaos/modus-themes
that referenced
this pull request
Aug 2, 2022
centaur-tabs has a bug where it cannot read the value of a face if it uses the standard ':inherit' attribute. I have sent a patch to fix it, but have received no response since February: <ema2159/centaur-tabs#179>. Relevant reports: - <#30> - <https://gitlab.com/protesilaos/modus-themes/-/issues/288> - <#15> I am happy to reinstate support for centaur-tabs as soon as the package gets the maintenance it needs.
|
Hey! I am back. Will review and push soon. Shouldn't take long. |
|
Thanks a lot for your contribution, and sorry for the delay. |
|
@ema2159 You are welcome! |
|
Also, eac6522 solves the issue @CsBigDataHub pointed out. |
protesilaos
added a commit
to protesilaos/modus-themes
that referenced
this pull request
Sep 20, 2022
I had removed support for centaur-tabs in commit 2235ce5 (done on 2022-08-02). I wrote: centaur-tabs has a bug where it cannot read the value of a face if it uses the standard ':inherit' attribute. I have sent a patch to fix it, but have received no response since February: <ema2159/centaur-tabs#179>. Relevant reports: - <#30> - <https://gitlab.com/protesilaos/modus-themes/-/issues/288> - <#15> I am happy to reinstate support for centaur-tabs as soon as the package gets the maintenance it needs. My patch/pull-request is now merged and the package is actively maintained once again. Hence the decision to bring back support for it, as promised.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old design would return an inappropriate nil value if the referenced face did not have an explicit background attribute. This can happen if a theme uses ':inherit' instead of specifying the face attributes directly.
By declaring a fallback value, we make sure that such indirection will note return a nil value.
This is related to issue 178: #178.