Prepare Release 0.28.1 #4299
Merged
Prepare Release 0.28.1 #4299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…me.Now() to 1 per iteration Signed-off-by: Evgeny Kuzin <evgeny.kuzin@outlook.com>
…0 and use `version.ComponentUserAgent` Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
chore(deps): use `version.ComponentUserAgent`
Fixed a formatting error that made the <slack_config> section unavailable from the menu in the web documentation Signed-off-by: Oleg Nikachev <oleg.a.nikachev@ringcentral.com>
Update to current Node/Debian Docker image. * Bump elm-format to current release. Signed-off-by: SuperQ <superq@gmail.com>
Bump UI docker image
Signed-off-by: Alex Weaver <weaver.alex.d@gmail.com>
Fixed formatting error
Signed-off-by: George Robinson <george.robinson@grafana.com>
Signed-off-by: Reto Kupferschmid <kupferschmid@puzzle.ch>
* Add wrap to content of adapter card to avoid truancating long text Signed-off-by: Dima Xu <dima.xu@orionhealth.com> Co-authored-by: Dima Xu <dima.xu@orionhealth.com>
Signed-off-by: Anastasios_Dados <tdados@hotmail.com>
…on (#4258) The update addresses failing GitHub Actions caused by the deprecation of v3 actions/upload-artifact and actions/download-artifact APIs. This change: - Updates promci from previous version to v0.4.6 - I hope resolves CI failures in artifact upload/download steps Signed-off-by: Raúl Naveiras <me@raulnaveiras.com>
…on (#4259) Same as #4258 The update addresses failing GitHub Actions caused by the deprecation of v3 actions/upload-artifact and actions/download-artifact APIs. This change: - Updates promci from previous version to v0.4.6 - I hope resolves CI failures in artifact upload/download steps https://github.com/prometheus/promci/releases/tag/v0.4.6 https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/ Signed-off-by: Raúl Naveiras <me@raulnaveiras.com>
This commit fixes a subtle bug introduced in #4177 where external code that imports config.InhibitRule for the purpose of JSON/YAML encoding can encode an inhibition rule with missing equals labels. This bug will happen if someone updates their Go modules, writes labels to the Equal field, and does not also write the same labels to the EqualStr field. To fix this, I propose removing EqualStr and changing Equal from model.LabelNames to []string. This will cause an intentional breaking change, and require the maintainer of downstream code to use []string instead of model.LabelNames. I consider this a better option to the subtle bug explained earlier. This still keeps the fix for #4177, but does so with an explicit breaking change to downstream users. Signed-off-by: George Robinson <george.robinson@grafana.com>
…breaking-change-4177 Fix subtle bug in JSON/YAML encoding of inhibition rules
* render jira project when searching existing issues Signed-off-by: Walther Lee <walther.lee@reddit.com> * golangci-lint run --fix Signed-off-by: Walther Lee <walther.lee@reddit.com> --------- Signed-off-by: Walther Lee <walther.lee@reddit.com> Co-authored-by: Walther Lee <walther.lee@reddit.com>
* opsgenie : trim space for api key file Signed-off-by: zoov-xavier <xavier.jeanneney@fifteen.eu> * fix lint checking error Signed-off-by: gotjosh <josue.abreu@gmail.com> --------- Signed-off-by: zoov-xavier <xavier.jeanneney@fifteen.eu> Signed-off-by: gotjosh <josue.abreu@gmail.com> Co-authored-by: gotjosh <josue.abreu@gmail.com>
* Fix descriptions for --enable-feature Signed-off-by: Andrés Maldonado <maldonado@codelutin.com> * Apply suggested changes Co-authored-by: George Robinson <george.robinson@grafana.com> Signed-off-by: am97 <amaldona@tutanota.com> --------- Signed-off-by: Andrés Maldonado <maldonado@codelutin.com> Signed-off-by: am97 <amaldona@tutanota.com> Co-authored-by: George Robinson <george.robinson@grafana.com> Co-authored-by: gotjosh <josue.abreu@gmail.com>
Signed-off-by: Reto Kupferschmid <kupferschmid@puzzle.ch> Co-authored-by: gotjosh <josue.abreu@gmail.com>
Fix rocketchat channel templating
replace Resolved with ResolvedAt to reduce amount call to time.Now()
Signed-off-by: Jan-Otto Kröpke <mail@jkroepke.de>
amtool: fix panic if --verbose is in used.
grobinson-grafana
force-pushed
the
grobinson/v0.28.1
branch
from
35466a5 to
ee3eeb1
Compare
SuperQ
approved these changes
Mar 7, 2025
Collaborator
Author
Member
|
I'm not sure what's wrong but apparently there are 4 commits that are expected to be sign-off in a slightly different format: https://github.com/prometheus/alertmanager/pull/4299/checks?check_run_id=38364172971 I'm going to set the DCO to pass manually as all the commits have been sign off one way or the other. |
Member
|
Yea, sometimes merging branches / cherry-pick in confuses the DCO checker. |
Signed-off-by: George Robinson <george.robinson@grafana.com>
grobinson-grafana
force-pushed
the
grobinson/v0.28.1
branch
from
ee3eeb1 to
53ba378
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--verbose. amtool: fix panic if --verbose is in used. #4218rocketchat_configswritten asrocket_configsin docs. Fixed rocketchat_configs docs #4217--enable-featureflag. Fix descriptions for --enable-feature #4214slack_configsin docs. fix:(alertmanager/docs): header for slack config #4247