Skip to content

Fix format issues of msteams adapter card #4222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gotjosh merged 1 commit into from
Jan 30, 2025
Merged

Fix format issues of msteams adapter card #4222

gotjosh merged 1 commit into from
Jan 30, 2025

Conversation

@dimahsu
Copy link
Contributor

@dimahsu dimahsu commented Jan 30, 2025

  • Fix typo for 'weight' to correct format of title
  • Add wrap to content of adapter card to avoid truncating long text

@dimahsu dimahsu force-pushed the dimahsu/ms-teamsv2-rending-issues branch from 946de6f to 2516694 Compare January 30, 2025 00:10
@dimahsu
Copy link
Contributor Author

dimahsu commented Jan 30, 2025 •
edited
Loading

As PR #4160 was closed and PR #4106 is blocked by CI failure, raised this PR to make the fixes released a bit faster. Please close this PR if there are same fixes approved already. Thanks

@dimahsu dimahsu force-pushed the dimahsu/ms-teamsv2-rending-issues branch from 2516694 to b5a42c5 Compare January 30, 2025 00:17
* Fix typo for 'weight' to correct format of title
cc31fb1 
* Add wrap to content of adapter card to avoid truancating long text

Signed-off-by: Dima Xu <dima.xu@orionhealth.com>
@dimahsu dimahsu force-pushed the dimahsu/ms-teamsv2-rending-issues branch from b5a42c5 to cc31fb1 Compare January 30, 2025 01:05
@dimahsu
Copy link
Contributor Author

dimahsu commented Jan 30, 2025 •
edited
Loading

@zhan9san @grobinson-grafana @SuperQ could you please review this PR? Hopefully it can be included in the next release. Thanks

@gotjosh gotjosh merged commit b5d1a64 into prometheus:main Jan 30, 2025
11 checks passed
@gotjosh
Copy link
Member

gotjosh commented Jan 30, 2025

Thank you very much for your contribution!

@dimahsu dimahsu deleted the dimahsu/ms-teamsv2-rending-issues branch January 30, 2025 20:57
This was referenced Mar 7, 2025
Merged
Merged
@SungJin1212 SungJin1212 mentioned this pull request Mar 13, 2025
Merged
3 tasks
mgaurav pushed a commit to oodle-ai/alertmanager that referenced this pull request Mar 18, 2025
@dimahsu @mgaurav
* Fix typo for 'weight' to correct format of title (prometheus#4222)
0a21ae4 
* Add wrap to content of adapter card to avoid truancating long text

Signed-off-by: Dima Xu <dima.xu@orionhealth.com>
Co-authored-by: Dima Xu <dima.xu@orionhealth.com>
(cherry picked from commit b5d1a64)
@jackhodgkiss jackhodgkiss mentioned this pull request Apr 16, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@grobinson-grafana grobinson-grafana grobinson-grafana approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dimahsu @gotjosh @grobinson-grafana