Document that the hash exposed in alertmanager_config_hash is not cryptographically strong #4210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexweav
force-pushed
the
alexweav/document-config-hash
branch
from
5b75856 to
6f063ef
Compare
gotjosh
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This hash is presented to operators to track the contents of the Alertmanager config file.
The method used to calculate the hash takes only the lower 48 bits of an MD5 hash, in order to stuff the hash into the metric value.
Although this is probably obvious to many operators, I think it's worth documenting that this method isn't cryptographically strong and that collisions are common, to add an extra layer of discouragement for anybody from trying to use this metric for secure purposes.