-
Notifications
You must be signed in to change notification settings - Fork 703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a Kubernetes/Docker config #581
Conversation
Signed-off-by: Brian Redmond <brianisrunning@gmail.com>
Signed-off-by: Brian Redmond <brianisrunning@gmail.com>
Signed-off-by: Brian Redmond <brianisrunning@gmail.com>
ports: | ||
- containerPort: 9100 | ||
hostPort: 9100 | ||
name: https |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does windows_exporter support TLS?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do think TLS and auth need to be handled for this. I saw that TLS came up in the past for this project: #57
Also note that the linux prom node_exporter still has TLS as experimental. https://github.com/prometheus/node_exporter#tls-endpoint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool. I just was confused a bit when tested this solution.
Hey @chzbrgr71,
I suspect the container running the exporter is a bit "too isolated", so we'll just collect data on the container itself, but I haven't been able to validate this from my short time. Maybe @sachinmsft has some insights, or could ping someone from within the Hyper-V/Windows team with knowledge of how this would work? |
Hi @chzbrgr71 , If yes, then I don't think that you can achieve that by running the wmi-exporter inside the pod. reason being that Windows does not support privilege container so you can not run wmi-exporter in the node context. You have to run the wmi-exporter.exe on the node to get the node metrics. If you want to run it through K8s then you can use the Wins (https://github.com/rancher/wins) to run the process on the node through container. but it adds the dependency of running wins service on each Windows node beforehand. |
Thanks for taking a look at this. @sachinmsft - you are correct that I'm trying to get node metrics in the same fashion as node-exporter. It makes sense that this might not work in a Windows scenario. We're not really able to run the wmi-exporter on the node since this is being deployed on AKS and we're not able (allowed) to install software directly on the VM's. That might prevent us from using the Rancher Wins utility as well. If you have any other ideas, please let me know. We're seeing more and more AKS customers looking for this capability. |
Hi @chzbrgr71, |
Just to add on this.. conversation. The way you can collect the metrics data like other vendors like datadog, azmon is using named pipe. Here's a url which explains this. |
Where do you tell the Windows exporter to use the localhost listener as a target? |
Kubernetes now has support for HostProcess Containers so we can move forward with this PR 🥳 I've took this work and add the support for hostprocess here: https://github.com/jsturtevant/windows_exporter/tree/use-hostprocess @chzbrgr71 Let me know if you are interested in taking this forward otherwise I am happy to submit a separate PR. Couple screen shots of this working: |
ah you got here before me @jsturtevant 😄 |
Fantastic news! Let us know if it'll go in this or another PR and we can get it reviewed :) |
This is awesome. Great work here. This had dropped off my radar over 12 months ago and I know @jsturtevant and team put a lot of work upstream to make it work. Feel free to move forward with a PR on this since I don't have cycles now to look at it. |
opened a new PR: #864 /close |
This PR includes the resources needed to deploy to a container and run in Kubernetes.