Add HostProcess Container Configuration for k8s #864
Conversation
|
I know the requirements are hard to come by so for anyone that wants to try this out there are few options available currently: |
jsturtevant
force-pushed
the
use-hostprocess
branch
8 times, most recently
from
d0c0da6
to
0a4431e
Compare
|
@carlpett I've addressed all the feedback. Ready for a final review and to sort out the image pushing mechanism. We only need Linux machine and Container Registry since we are using buildx to create the image. |
|
Let me know if can help in anyway. |
|
@carlpett anything we can do to move this along? Is there a community meeting I can add it to the agenda? or maybe start a conversation in slack? |
|
Hi @jsturtevant, So I think the next step would be amending the release step to build and push the image. Something you'd be comfortable doing? |
|
sweet! I'll take a look tomorrow and see if I have questions. Thanks! |
|
Looked into it a bit and looks like the github action jobs are running on Windows. Buildx doesn't work on windows so I will need to adjust this a bit to build containers on Windows. Shouldn't be a big deal. I was also building the image in the container but you have the image on the build machine so I could just copy that into the container. This way its the same executable that is being released. |
jsturtevant
force-pushed
the
use-hostprocess
branch
5 times, most recently
from
f3e9a34
to
9caa917
Compare
I think it makes sense to have the build work on Windows since rest of the tooling is working there. I've pushed the changes to make this work on Windows github action runner as separate commit. I made minimal changes to make it work but let me know if you want a different approach. Can squash if you want me too. Note to build the multi arch image needed to use the WS2022 runners, which apparently don't have the |
jsturtevant
force-pushed
the
use-hostprocess
branch
2 times, most recently
from
8849fbd
to
6836d2a
Compare
|
This looks good to me, great work! 👏 |
|
I built an image with this code here: https://hub.docker.com/repository/docker/jsturtevant/windows-exporter if you want to try it out (requires k8s 1.22+ and containerd 1.6+) I will run a quick validation this afternoon. |
|
I validated it is working with that image. I will double check once there is a released image |
|
do you want me to squash the commits? |
| - args: | ||
| - --config.file=%CONTAINER_SANDBOX_MOUNT_POINT%/config.yml | ||
| name: windows-exporter | ||
| image: jsturtevant/windows-exporter:latest |
There was a problem hiding this comment.
@carlpett I need to update this but currently not pushing a latest tag. We won't have a tag until the git repository is tagged and released. Thoughts?
the current format is ghcr.io/prometheus-community/windows-exporter:<versionnumber>
There was a problem hiding this comment.
Based on other unreleased changes, the next version is going to be 0.18.
I'm not sure if we want a latest tag? On the other hand, documenting it as a fixed version, I doubt we'll remember to update it...
There was a problem hiding this comment.
Thinking some more, I think we'll want a "bleeding edge" image. For example, the node_exporter has a master tag. They also have a latest, pointing to latest release. I'm personally not a fan, but I suppose there's probably high demand for it?
There was a problem hiding this comment.
added a "bleeding" edge image. let me know if you want me to squash the commits
|
e2e test failed, It might have been a flake? I don't seem to be able to re-triger the job |
jsturtevant
force-pushed
the
use-hostprocess
branch
from
5c1ee37
to
32f8377
Compare
|
|
must be something else. I don't see anything in the directly in the output |
|
Yes, you'll need to rebase this PR on |
jsturtevant
force-pushed
the
use-hostprocess
branch
from
32f8377
to
56b3f58
Compare
|
@jsturtevant are you happy for this to be merged? I can't see any open threads besides the bleeding edge image, which has been implemented. |
Co-authored-by: Brian Redmond <brianisrunning@gmail.com> Signed-off-by: Brian Redmond <brianisrunning@gmail.com> Signed-off-by: James Sturtevant <jstur@microsoft.com>
jsturtevant
force-pushed
the
use-hostprocess
branch
from
56b3f58
to
b450a50
Compare
|
Yes let's do it 🥳 I just rebased to clean up the commits. |
…process Add HostProcess Container Configuration for k8s
Kubernetes now has support for HostProcess Containers so this is a continuation of #581 using HostProcess containers
Requirements: