use IsWindowsService to detect if running as service #863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: James Sturtevant <jstur@microsoft.com>
jsturtevant
force-pushed
the
fix-service-identification
branch
from
76d36bf
to
a6ea021
Compare
anubhavg-icpl
pushed a commit
to anubhavg-icpl/windows_exporter
that referenced
this pull request
Sep 22, 2024
…ice-identification use IsWindowsService to detect if running as service
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #856
When working on #581 (comment) I got the error
time="2021-11-05T00:18:54Z" level=error msg="Failed to start service: The service process could not connect to the service controller." source="exporter.go:337"It was not running as a service so it should not fall into this code path. I found https://pkg.go.dev/golang.org/x/sys/windows/svc#IsAnInteractiveSession was depreciated so made the switch.