Skip to content

Conversation

@SuperQ
Copy link
Contributor

@SuperQ SuperQ commented Jul 3, 2022

Breaking Change:

The exporter config file format has changed. It now supports multiple modules
to scrape different endpoints.

Closes: #158

Signed-off-by: SuperQ superq@gmail.com

@SuperQ SuperQ requested a review from rustycl0ck July 3, 2022 08:59
Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

Copy link
Member

@rustycl0ck rustycl0ck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, feel free to merge after a rebase for including #161

Breaking Change:

The exporter config file format has changed. It now supports multiple modules
to scrape different endpoints.

* [FEATURE] Support custom valuetype #145
* [FEATURE] Support modules configuration #146
* [FEATURE] Accept non-2xx HTTP status #161

Signed-off-by: SuperQ <superq@gmail.com>
@SuperQ SuperQ force-pushed the superq/release_0.5.0 branch from a859faf to 59477d6 Compare July 11, 2022 07:32
@SuperQ SuperQ merged commit 2c1ca88 into master Jul 11, 2022
@SuperQ SuperQ deleted the superq/release_0.5.0 branch July 11, 2022 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Issue with example

4 participants