Skip to content

support custom valuetype like counter, gauge or untyped #145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 23, 2022
Merged

support custom valuetype like counter, gauge or untyped #145

merged 2 commits into from
May 23, 2022

Conversation

@yeya24
Copy link
Contributor

@yeya24 yeya24 commented Mar 19, 2022

Signed-off-by: Ben Ye ben.ye@bytedance.com

Fixes #140

SuperQ
SuperQ requested changes May 23, 2022
View reviewed changes
Copy link
Contributor

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks.

Although, I think this needs a rebase due to recent changes.

support custom valuetype like counter, gauge or untyped
ae029f3 
Signed-off-by: Ben Ye <ben.ye@bytedance.com>
rebase latest master
81e6b14 
Signed-off-by: Ben Ye <ben.ye@bytedance.com>
@yeya24
Copy link
Contributor Author

yeya24 commented May 23, 2022

@SuperQ Updated.

SuperQ
SuperQ approved these changes May 23, 2022
View reviewed changes
Copy link
Contributor

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@SuperQ SuperQ merged commit d43d3ed into prometheus-community:master May 23, 2022
@yeya24 yeya24 deleted the value-type branch May 23, 2022 18:18
SuperQ added a commit that referenced this pull request Jul 3, 2022
@SuperQ
Release v0.5.0
a859faf 
Breaking Change:

The exporter config file format has changed. It now supports multiple modules
to scrape different endpoints.

* [FEATURE] Support custom valuetype #145
* [FEATURE] Support modules configuration #146

Signed-off-by: SuperQ <superq@gmail.com>
@SuperQ SuperQ mentioned this pull request Jul 3, 2022
Merged
SuperQ added a commit that referenced this pull request Jul 11, 2022
@SuperQ
Release v0.5.0
59477d6 
Breaking Change:

The exporter config file format has changed. It now supports multiple modules
to scrape different endpoints.

* [FEATURE] Support custom valuetype #145
* [FEATURE] Support modules configuration #146
* [FEATURE] Accept non-2xx HTTP status #161

Signed-off-by: SuperQ <superq@gmail.com>
SuperQ added a commit that referenced this pull request Jul 11, 2022
@SuperQ
Release v0.5.0 (#166)
2c1ca88 
Breaking Change:

The exporter config file format has changed. It now supports multiple modules
to scrape different endpoints.

* [FEATURE] Support custom valuetype #145
* [FEATURE] Support modules configuration #146
* [FEATURE] Accept non-2xx HTTP status #161

Signed-off-by: SuperQ <superq@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SuperQ SuperQ SuperQ approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Untyped metrics

2 participants

@yeya24 @SuperQ